Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
Technical Details
Ieee80211*spec types to theDot11*API types.Test Results
netremote-cliand ensured no crashes occurred. Also attached a debugger to the server side and inspected the fully built protobuf object which appeared to be correct, excepting the known issues (see Future Work section below).Reviewer Focus
Ieee80211*toDot11*API types makes sense and/or whether there are cases where the mapping is not 1-1.Future Work
Dot11AuthenticationAlgorithmprotobuf enumeration currently reflects Windows view of 802.11 authentication algorithms, however, it appears more like an 802.11 AKM instead. As such, there is no direct mapping(s) from theIeee80211AuthenticationAlgorithmenumeration. An API breaking change will be needed to fix this, @corbin-phipps FYI.netremote-clitool needs to be updated to display the capabilities information.Checklist
allcompiles cleanly.