Fix xtra args positioning for hostapd systemd service unit file (again)#111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
Technical Details
hostapdis picky and expects the configuration file argument to come directly after the-iflag, so any extra arguments must be positioned prior to this flag. So, move${HOSTAPD_XTRA_ARGS}to be the first argument forhostapd.Test Results
sudo systemctl start hostapd@wlx08beac0696feon a Linux machine and ensured the hostapd service came up:shadowfax@mrstux:/etc/systemd/system$ sudo systemctl status hostapd@wlx08beac0696fe ● hostapd@wlx08beac0696fe.service - Hostapd Daemon Loaded: loaded (/etc/systemd/system/hostapd@.service; disabled; preset: enabled) Active: active (running) since Thu 2024-01-18 17:17:29 UTC; 5min ago Main PID: 24752 (hostapd) Tasks: 1 (limit: 18968) Memory: 1.0M CPU: 1.371s CGroup: /system.slice/system-hostapd.slice/hostapd@wlx08beac0696fe.service └─24752 /home/shadowfax/src/microsoft/netremote-cmake/out/install/dev-linux/sbin/hostapd -i wlx08beac0696fe /etc/hostapd/hostapd-wlx08beac0696fe.conf Jan 18 17:17:29 mrstux systemd[1]: Started hostapd@wlx08beac0696fe.service - Hostapd Daemon. Jan 18 17:17:30 mrstux hostapd[24752]: wlx08beac0696fe: interface state UNINITIALIZED->ENABLED Jan 18 17:17:30 mrstux hostapd[24752]: wlx08beac0696fe: AP-ENABLEDReviewer Focus
Future Work
Checklist
allcompiles cleanly.