Skip to content

Add the ability to provide extra command line arguments to hostapd and netremote-server#106

Merged
abeltrano merged 4 commits into
developfrom
argsxtra
Jan 12, 2024
Merged

Add the ability to provide extra command line arguments to hostapd and netremote-server#106
abeltrano merged 4 commits into
developfrom
argsxtra

Conversation

@abeltrano
Copy link
Copy Markdown
Contributor

@abeltrano abeltrano commented Jan 12, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow specifying extra command line arguments to hostapd and netremote-server binaries.

Technical Details

  • Append environment variables HOSTAPD_XTRA_ARGS and NETREMOTE_SERVER_XTRA_ARGS to the ExecStart directives in each of the corresponding unit files, allowing additional arguments to be specified to their command line.
  • Add the online network target as dependency of netremote-server unit to ensure networking comes online before the service is started.

Test Results

  • systemctl edit hostapd@wlan0 and added the following line to override.conf drop-in:
[Service]
HOSTAPD_XTRA_ARGS="-ddddd"

Then systemctl restart hostapd@wlan0 and validated that verbose debug output was available in journalctl output for the unit.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 12, 2024 16:22
@abeltrano abeltrano merged commit 88f0060 into develop Jan 12, 2024
@abeltrano abeltrano deleted the argsxtra branch January 12, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant