Skip to content

Add interface for controlling access points#102

Merged
abeltrano merged 9 commits into
developfrom
apmgmtimpl
Jan 11, 2024
Merged

Add interface for controlling access points#102
abeltrano merged 9 commits into
developfrom
apmgmtimpl

Conversation

@abeltrano
Copy link
Copy Markdown
Contributor

@abeltrano abeltrano commented Jan 11, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow more control over how access points are created and how they are used.

Technical Details

  • Add helper Nl80211ProtocolState to obtain and store state related to the nl80211 protocol.
  • Add Nl80211MulticastGroup enumeration for referencing nl80211 multicast groups easier.
  • Add unit tests for nl80211 helper code.
  • Add IAccessPointController interface for controlling access points.
  • Implement shared IAccessPointController behavior in AccessPointController.
  • Partially implement NetRemoteService::WifiEnumerateAccessPoints API to allow clients to invoke it and obtain access point identifiers in the result, using AccessPointManager.
  • Fix numbering in protobuf Dot11CipherAlgorithm entries.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • Extend IAccessPointController with necessary operations.
  • Use Nl80211ProtocolState data in AccessPointDiscoveryAgentOperationsNetlink impl.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 11, 2024 20:31
@abeltrano abeltrano merged commit 3bd0c94 into develop Jan 11, 2024
@abeltrano abeltrano deleted the apmgmtimpl branch January 11, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant