Skip to content

MdePkg: BasePeCoffLib: Record security data directory#1844

Draft
Javagedes wants to merge 1 commit into
microsoft:release/202511from
Javagedes:personal/joeyvagedes/sec-data-dir
Draft

MdePkg: BasePeCoffLib: Record security data directory#1844
Javagedes wants to merge 1 commit into
microsoft:release/202511from
Javagedes:personal/joeyvagedes/sec-data-dir

Conversation

@Javagedes

Copy link
Copy Markdown
Contributor

NOTE: This is a draft PR so that the team can review it before I put it up to EDK II. This is to support The Dxe Image Validation changes that are being made.

Description

Add a new field, SecurityDataDirectory, to PE_COFF_LOADER_IMAGE_CONTEXT that records the security data directory of the image. This occurs when PeCoffLoaderGetImageInfo is called.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

N/A

Integration Instructions

N/A

Add a new field, SecurityDataDirectory, to PE_COFF_LOADER_IMAGE_CONTEXT
that records the security data directory of the image. This occurs when
PeCoffLoaderGetImageInfo is called.

Signed-off-by: Joey Vagedes <joey.vagedes@gmail.com>
@mu-automation

mu-automation Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

❌ QEMU Validation Failed

Source Dependencies

Repository Commit
mu_basecore a6ddf4c
mu_tiano_platforms 49baa9b

Results

Platform Target Build Boot Overall Boot Time Build Logs Boot Logs
Q35 DEBUG ❌ failure ⏩ skipped N/A Build Logs N/A
ArmVirt DEBUG ✅ success ✅ success 0m 14s Build Logs Boot Logs

Workflow run: https://github.com/microsoft/mu_basecore/actions/runs/29039068246

This comment was automatically generated by the Mu QEMU PR Validation workflow.

@Javagedes
Javagedes requested review from apop5, makubacki and os-d July 9, 2026 17:52
@codecov-commenter

codecov-commenter commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/202511@5315549). Learn more about missing BASE report.

Files with missing lines Patch % Lines
MdePkg/Library/BasePeCoffLib/BasePeCoff.c 0.00% 20 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/202511    #1844   +/-   ##
=================================================
  Coverage                  ?    2.25%           
=================================================
  Files                     ?     1640           
  Lines                     ?   421479           
  Branches                  ?     5048           
=================================================
  Hits                      ?     9501           
  Misses                    ?   411894           
  Partials                  ?       84           
Flag Coverage Δ
FmpDevicePkg 9.53% <ø> (?)
MdeModulePkg 1.65% <ø> (?)
MdePkg 5.44% <0.00%> (?)
NetworkPkg 0.55% <ø> (?)
PolicyServicePkg 30.42% <ø> (?)
SecurityPkg 1.56% <ø> (?)
UefiCpuPkg 4.78% <ø> (?)
UnitTestFrameworkPkg 11.70% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants