Return ESPIPE for pread/pwrite on non-seekable files#818
Open
Conversation
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
CvvT
changed the title
jaybosamiya-ms
approved these changes
Apr 28, 2026
Member
jaybosamiya-ms
left a comment
jaybosamiya-ms
left a comment
There was a problem hiding this comment.
Thanks Weiteng, just a minor nit on naming
| } | ||
| } | ||
|
|
||
| fn reject_offset_for_non_seekable(offset: Option<usize>) -> Result<(), Errno> { |
Member
There was a problem hiding this comment.
Nit: this name does not imply it'll return with ESPIPE so may end up confusing if some other offset stuff shows up later; maybe consider espipe_for_non_seekable_offset?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pread64/pwrite64must fail with-ESPIPEwhen the file descriptor refers to a pipe, socket, FIFO, or any other non-seekable object.