Open
Conversation
sangho2
commented
Apr 11, 2026
sangho2
force-pushed
the
sanghle/lvbs/fix_mem_protection_range
branch
2 times, most recently
from
c58e8d6 to
b443bd8
Compare
sangho2
force-pushed
the
sanghle/lvbs/fix_mem_protection_range
branch
4 times, most recently
from
c71d1d1 to
666ce54
Compare
wdcui
reviewed
May 8, 2026
| ); | ||
|
|
||
| if is_bsp { | ||
| if let Ok((start, size)) = get_vtl1_memory_info() { |
Member
There was a problem hiding this comment.
Does get_vtl1_memory_info() guarantee to return page aligned start and size?
Member
There was a problem hiding this comment.
Are all HEKI kexec/trampoline physical ranges guaranteed to be page-aligned?
Contributor
Author
There was a problem hiding this comment.
Yes. These start and size are from early boot and they are trusted. If they are malformed, no way to securely boot this VM. And we do use containing_address.
Contributor
Author
There was a problem hiding this comment.
HekiPage data structure does have an is_valid method for various sanity checks.
sangho2
force-pushed
the
sanghle/lvbs/fix_mem_protection_range
branch
from
666ce54 to
b11dc14
Compare
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardens the VTL memory protection function(s). Currently, the VTL memory protection function doesn't check whether the given physical memory range belongs to VTL0 or VTL1. This potentially lets the adversary tamper with the VTL1's memory protection.