Conversation
jaybosamiya-ms
approved these changes
Mar 7, 2025
Member
There was a problem hiding this comment.
Changes look good to me, thanks!
GitHub Actions gave the 👀 because of this check:
--- failure trait_method_parameter_count_changed: pub trait method parameter count changed ---
Description:
A trait method now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/trait_method_parameter_count_changed.ron
Failed in:
FileSystem::read now takes 4 instead of 3 parameters, in file /home/runner/work/litebox/litebox/litebox/src/fs/mod.rs:51
FileSystem::write now takes 4 instead of 3 parameters, in file /home/runner/work/litebox/litebox/litebox/src/fs/mod.rs:57
This is an expected change in interface via this PR
wdcui
approved these changes
Mar 7, 2025
Member
|
Feel free to merge, @CvvT |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support pread/pwrite. Compared to
read/write, the only difference is whether it needs to update the file offset.