This repository was archived by the owner on May 29, 2026. It is now read-only.
Fix generateImage edit mode content type error by using global.fetch for FormData#1914
Merged
Merged
Conversation
…for FormData Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate https://github.com/microsoft/genaiscript/issues/1913 and fix the issue.
Fix generateImage edit mode content type error by using global.fetch for FormData
Aug 29, 2025
pelikhan
approved these changes
Aug 30, 2025
Contributor
|
Warning LLM error (403): error
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1913 where
generateImagein edit mode was throwing:Problem
The
OpenAIImageGenerationfunction was using thecreateFetchwrapper (cross-fetch) for all requests, including FormData requests in edit mode. Cross-fetch doesn't properly handle FormData content types and defaults totext/plaininstead of letting FormData set the propermultipart/form-databoundary.Solution
Modified the image generation to conditionally use
global.fetchfor multipart requests (edit mode with FormData) and thecreateFetchwrapper for JSON requests (generate mode):This follows the same pattern already used in other parts of the codebase (WhisperASR transcription, speech generation) where FormData requires proper handling.
Testing
test/image-generation.test.tswith new test cases for both edit and generate modesThe fix is minimal and surgical, maintaining backward compatibility while resolving the regression that broke image editing functionality.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn.sheetjs.comnode /home/REDACTED/.local/share/pnpm/.tools/pnpm/10.12.3/bin/pnpm install(dns block)esm.ubuntu.com/usr/lib/apt/methods/https(dns block)example.comnode (vitest 3)(dns block)https://api.github.com/markdownnode (vitest 3)(http block)https://api.github.com/repos/microsoft/genaiscript/branchesnode (vitest 3)(http block)https://api.github.com/repos/microsoft/genaiscript/contents/README.mdnode (vitest 3)(http block)https://api.github.com/repos/microsoft/genaiscript/contents/packages%2Fcore%2Fsrcnode (vitest 3)(http block)https://api.github.com/repos/microsoft/genaiscript/git/blobsnode (vitest 3)(http block)https://api.github.com/repos/microsoft/genaiscript/git/ref/heads%2Ftest-ignorenode (vitest 3)(http block)https://api.github.com/repos/microsoft/genaiscript/issuesnode (vitest 3)(http block)https://api.github.com/repos/microsoft/genaiscript/labelsnode (vitest 3)(http block)https://api.github.com/repos/microsoft/genaiscript/languagesnode (vitest 3)(http block)https://api.github.com/repos/microsoft/genaiscript/pullsnode (vitest 3)(http block)https://api.github.com/repos/microsoft/genaiscript/pulls/999999node (vitest 2)(http block)https://api.github.com/testnode (vitest 3)(http block)microsoft.github.ionode (vitest 1)(dns block)node (vitest 3)(dns block)telemetry.astro.buildIf you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.