Sketch out quantization tasks and calls into DiskANN#1726
Draft
kevin-montrose wants to merge 22 commits into
Draft
Sketch out quantization tasks and calls into DiskANN#1726kevin-montrose wants to merge 22 commits into
kevin-montrose wants to merge 22 commits into
Conversation
…uired by the time we get around to it
…ackground quantization of Vector Sets
…e yet; rename quantizers and vector value to better align with expectations; add xbin_i8 quantizer; stop asking diskann to handle all vector formats, instead just use the quantizer to pick a 'native' vector type and map to those types as needed; handle alignement requirements on Garnet side as well
…b.com/microsoft/garnet into users/kmontrose/vectorSetQuantization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change expected return from DiskANN's
insertso we can signal a request to quantize.Spin up tasks to pump background quantization when that is requested.
Tasks take two forms:
build_quant_table(context, index)backfill_quant_vectors(context, index, task_index, task_count)It's on DiskANN to find vectors to backfill and split them up based on
task_index / task_count.Since locks are not held over the entire backfill, DiskANN also needs to validate that quantization is still needed when
build_quant_tableis called (recreation and restarts can mess with that) andbackfill_quant_vectorsneeds to gracefully deal with concurrent calls.Upon further discussion, we're also cleaning up quantizer options and the FFI between Garnet and DiskANN around vector formats.
Namely:
XPREQ8->XNOQUANT_U8XBIN_I8XB8->XU8XI8Old options are aliased so we can keep
XPREQ8andXB8in tests and whatnot without issue.