Fix LogsCommand to sort results by timestamp#14645
Merged
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14645Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14645" |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Aspire CLI logs command so that when aggregating logs from multiple resources, the output is sorted globally by timestamp (follow-up to #14632), and adjusts unit tests to validate the new ordering.
Changes:
- Refactors
LogsCommandto parse log lines intoLogEntryobjects and emit results sorted by timestamp. - Updates JSON and text output paths to use the parsed entries (including resolved resource prefixes).
- Revises
LogsCommandTestsexpectations and test data to verify cross-resource timestamp sorting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Aspire.Cli/Commands/LogsCommand.cs | Refactors log collection/output to sort entries by timestamp across resources. |
| tests/Aspire.Cli.Tests/Commands/LogsCommandTests.cs | Updates tests and fixtures to assert the new timestamp-sorted behavior. |
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22346761059 |
This was referenced Feb 24, 2026
IEvangelist
approved these changes
Feb 24, 2026
Contributor
|
|
Member
This recording seems to not have that 5+s delay you were seeing: https://asciinema.org/a/t1K6ivY4O0yOFyrL |
Contributor
|
Hmmm, let me verify I am using the right one |
Contributor
|
➜ aspire --version |
Contributor
Screen.Recording.2026-02-24.103754.mp4 |
Member
Author
|
It's much faster than it use to be for multiple resources. Now logs are fetched in parallel. 5 seconds vs 20+ seconds. I think the delay at this point is coming from getting logs from DCP. How about:
|
Contributor
|
Merge this PR, lets file a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14646
Follow up to #14632. Logs for multiple resources weren't sorted by timestamp across resources
Changes:
GetResourceLogsAsyncto not be a mess of branchesChecklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: