Skip to content

fix: resolve set() shadowing and sparse checkout ref issues #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielmeppiel merged 2 commits into from
Mar 6, 2026
Merged

fix: resolve set() shadowing and sparse checkout ref issues #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d792b24
fix: resolve set() shadowing and sparse checkout ref issues
Jah-yee Mar 6, 2026
b36084d
Update src/apm_cli/deps/github_downloader.py
Jah-yee Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/apm_cli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1841,7 +1841,7 @@ def download_callback(dep_ref, modules_dir):
_dl_progress.remove_task(_pd_tid)
# Silent: sequential loop below will retry and report errors

_pre_downloaded_keys = set(_pre_download_results.keys())
_pre_downloaded_keys = builtins.set(_pre_download_results.keys())

# Create progress display for sequential integration
with Progress(
Expand Down
3 changes: 1 addition & 2 deletions src/apm_cli/deps/github_downloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,8 +1073,7 @@ def _try_sparse_checkout(self, dep_ref: DependencyReference, temp_clone_path: Pa
['git', 'sparse-checkout', 'set', subdir_path],
]
fetch_cmd = ['git', 'fetch', 'origin']
if ref:
fetch_cmd.append(ref)
fetch_cmd.append(ref or 'HEAD')
fetch_cmd.append('--depth=1')
Comment thread
Jah-yee marked this conversation as resolved.
cmds.append(fetch_cmd)
cmds.append(['git', 'checkout', 'FETCH_HEAD'])
Expand Down