fix paste edits range: include all completely selected identifiers#60339
Merged
iisaduan merged 5 commits intomicrosoft:mainfrom Oct 29, 2024
Merged
fix paste edits range: include all completely selected identifiers#60339iisaduan merged 5 commits intomicrosoft:mainfrom
iisaduan merged 5 commits intomicrosoft:mainfrom
Conversation
iisaduan
requested review from
andrewbranch,
gabritto,
navya9singh and
sandersn
typescript-bot
added
For Uncommitted Bug
sandersn
approved these changes
Oct 29, 2024
src/services/pasteEdits.ts
Outdated
Comment on lines
180
to
181
| // This function adjusts the range so that identifiers at the edges of the copied text are correctly included for imports. | ||
| // We do not need to adjust range when the tokens at the edges are not identifiers. |
Member
There was a problem hiding this comment.
This should be jsdoc. At least, it seems like the comments are intended for callers of the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60246
When checking usage info for paste edits, adjust the range to be node-based instead of purely position based, so identifiers at the edges of the copied range can be correctly resolved. Because of how whitespace/trivia is included in nodes, before, if trivia wasn't completely copied, some identifiers were skipped when checking for usage.
Only the first commit is the bug fix, the rest are tests and a small refactor in
pasteEdits.