Conversation
weswigham
approved these changes
Oct 17, 2024
Member
|
Was there a typo? #41533 seems unrelated. Should this have waited for 5.8 since it's an emit change? |
Contributor
Author
|
It's a bugfix to an emit helper and I would say the risk of it being an issue is fairly small given that it is more permissive. Going the other direction I mentioned in the OP would have needed to wait for 5.8 as it would be a breaking change. |
Contributor
Author
This was referenced Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the
__importStarhelper to include non-enumerable own keys to ensure the following two cases are consistent:vs
The discrepancy occurs when the module
"mod"produces exports that are non-enumerable, such as:In the above case,
C.bis an own static method ofCwhich makes it non-enumerable by default.The other way to address this would be to also wrap
mod_2'srequirein__importStarso that we apply the rule consistently in both cases, but that would be a major breaking change as it has the potential to break existing users w/o warning.The companion PR for
tslibcan be found at microsoft/tslib#272.Fixes #45133