Fix prioritization of paths specifiers over node_modules package specifiers#60238
Merged
andrewbranch merged 1 commit intomicrosoft:mainfrom Oct 23, 2024
Merged
Fix prioritization of paths specifiers over node_modules package specifiers#60238andrewbranch merged 1 commit intomicrosoft:mainfrom
paths specifiers over node_modules package specifiers#60238andrewbranch merged 1 commit intomicrosoft:mainfrom
Conversation
typescript-bot
added
Author: Team
For Milestone Bug
iisaduan
approved these changes
Oct 23, 2024
Member
iisaduan
left a comment
iisaduan
left a comment
There was a problem hiding this comment.
Big diff difference reviewing with and without whitespace changes :D
This was referenced Jun 9, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51398
Review with whitespace changes hidden. Slightly above the diff that GitHub shows is a comment outlining the module specifier priority intended, but it wasn’t working in this case where
pathspoints to something inside node_modules.