Fixed regression in generic signature instantiation with default type args by Andarist · Pull Request #59510 · microsoft/TypeScript

Andarist · 2024-08-02T07:52:49Z

fixes #59490

complements the fix from #59121 so the correct cloned type parameter is used as the inference target

cc @weswigham

… args

jakebailey · 2024-08-02T08:08:39Z

@typescript-bot test it

typescript-bot · 2024-08-02T08:08:42Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-08-02T08:41:59Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-08-02T08:43:04Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59510/merge:

Everything looks good!

typescript-bot · 2024-08-02T08:57:00Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,901k (± 0.72%)}	_{194,122k (± 1.00%)}	_~	_192,316k	_195,907k	_{p=0.173 n=6}
_{Parse Time}	_{1.57s (± 0.74%)}	_{1.56s (± 0.91%)}	_~	_1.54s	_1.58s	_{p=0.325 n=6}
_{Bind Time}	_{0.86s (± 1.36%)}	_{0.86s (± 0.95%)}	_~	_0.85s	_0.87s	_{p=0.738 n=6}
_{Check Time}	_{11.39s (± 0.33%)}	_{11.38s (± 0.30%)}	_~	_11.33s	_11.43s	_{p=0.627 n=6}
_{Emit Time}	_{3.26s (± 0.75%)}	_{3.26s (± 0.69%)}	_~	_3.23s	_3.29s	_{p=0.683 n=6}
_{Total Time}	_{17.08s (± 0.32%)}	_{17.05s (± 0.12%)}	_~	_17.02s	_17.08s	_{p=0.518 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,537	_945,537	_~	_~	_~	_{p=1.000 n=6}
_Types	_409,512	_409,512	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,226k (± 0.00%)}	_{1,222,246k (± 0.00%)}	_~	_1,222,204k	_1,222,286k	_{p=0.378 n=6}
_{Parse Time}	_{7.86s (± 0.29%)}	_{7.88s (± 0.56%)}	_~	_7.84s	_7.96s	_{p=0.571 n=6}
_{Bind Time}	_{2.21s (± 0.44%)}	_{2.22s (± 1.44%)}	_~	_2.19s	_2.28s	_{p=0.932 n=6}
_{Check Time}	_{36.22s (± 0.45%)}	_{36.22s (± 0.42%)}	_~	_35.99s	_36.40s	_{p=1.000 n=6}
_{Emit Time}	_{17.75s (± 0.64%)}	_{17.75s (± 0.52%)}	_~	_17.59s	_17.84s	_{p=0.810 n=6}
_{Total Time}	_{64.04s (± 0.32%)}	_{64.07s (± 0.33%)}	_~	_63.87s	_64.44s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,439,302	_2,439,302	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,004,512	_1,004,512	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,412,743k (± 0.00%)}	_{2,412,746k (± 0.00%)}	_~	_2,412,683k	_2,412,830k	_{p=0.936 n=6}
_{Parse Time}	_{8.51s (± 0.22%)}	_{8.48s (± 0.18%)}	_~	_8.47s	_8.51s	_{p=0.071 n=6}
_{Bind Time}	_{2.08s (± 0.43%)}	_{2.08s (± 0.26%)}	_~	_2.07s	_2.08s	_{p=0.341 n=6}
_{Check Time}	_{75.06s (± 0.94%)}	_{75.04s (± 1.38%)}	_~	_74.24s	_76.95s	_{p=0.689 n=6}
_{Emit Time}	_{0.28s (± 2.70%)}	_{0.28s (± 1.92%)}	_~	_0.28s	_0.29s	_{p=0.137 n=6}
_{Total Time}	_{85.93s (± 0.83%)}	_{85.88s (± 1.20%)}	_~	_85.09s	_87.78s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,919	_1,227,922	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,192	_265,193	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,524,979k (±11.77%)}	_{2,465,591k (±11.75%)}	_~	_2,346,774k	_3,057,676k	_{p=0.471 n=6}
_{Parse Time}	_{7.47s (± 0.85%)}	_{7.47s (± 1.59%)}	_~	_7.39s	_7.71s	_{p=0.748 n=6}
_{Bind Time}	_{2.78s (± 1.17%)}	_{2.78s (± 1.00%)}	_~	_2.73s	_2.81s	_{p=0.569 n=6}
_{Check Time}	_{50.64s (± 0.84%)}	_{50.69s (± 0.54%)}	_~	_50.35s	_51.06s	_{p=1.000 n=6}
_{Emit Time}	_{4.98s (± 3.54%)}	_{5.06s (± 4.04%)}	_~	_4.86s	_5.31s	_{p=0.689 n=6}
_{Total Time}	_{65.91s (± 0.82%)}	_{66.01s (± 0.29%)}	_~	_65.80s	_66.35s	_{p=0.748 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,919	_1,227,922	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,192	_265,193	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,420,997k (± 0.03%)}	_{2,446,464k (± 2.59%)}	_~	_2,419,813k	_2,576,143k	_{p=0.810 n=6}
_{Parse Time}	_{6.22s (± 0.60%)}	_{6.24s (± 0.76%)}	_~	_6.17s	_6.31s	_{p=0.520 n=6}
_{Bind Time}	_{2.05s (± 0.82%)}	_{2.04s (± 0.51%)}	_~	_2.02s	_2.05s	_{p=0.138 n=6}
_{Check Time}	_{41.15s (± 0.26%)}	_{41.41s (± 0.67%)}	_~	_41.19s	_41.93s	_{p=0.054 n=6}
_{Emit Time}	_{4.09s (± 3.17%)}	_{4.05s (± 1.14%)}	_~	_3.99s	_4.13s	_{p=0.936 n=6}
_{Total Time}	_{53.53s (± 0.37%)}	_{53.75s (± 0.53%)}	_~	_53.50s	_54.28s	_{p=0.173 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,031	_256,034	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,976	_104,977	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{427,931k (± 0.02%)}	_{427,900k (± 0.01%)}	_~	_427,848k	_428,007k	_{p=0.873 n=6}
_{Parse Time}	_{4.16s (± 0.33%)}	_{4.15s (± 0.53%)}	_~	_4.12s	_4.18s	_{p=0.565 n=6}
_{Bind Time}	_{1.64s (± 0.67%)}	_{1.62s (± 1.56%)}	_~	_1.57s	_1.64s	_{p=0.063 n=6}
_{Check Time}	_{22.19s (± 0.53%)}	_{22.28s (± 0.35%)}	_~	_22.18s	_22.38s	_{p=0.298 n=6}
_{Emit Time}	_{2.02s (± 0.92%)}	_{2.03s (± 0.88%)}	_~	_2.00s	_2.05s	_{p=0.685 n=6}
_{Total Time}	_{30.01s (± 0.38%)}	_{30.08s (± 0.36%)}	_~	_29.92s	_30.23s	_{p=0.335 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,931	_224,931	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,146	_94,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,126k (± 0.03%)}	_{370,176k (± 0.02%)}	_~	_370,060k	_370,321k	_{p=0.230 n=6}
_{Parse Time}	_{2.76s (± 0.59%)}	_{2.77s (± 0.71%)}	_~	_2.74s	_2.79s	_{p=0.370 n=6}
_{Bind Time}	_{1.58s (± 1.16%)}	_{1.58s (± 0.93%)}	_~	_1.56s	_1.60s	_{p=0.681 n=6}
_{Check Time}	_{15.67s (± 0.21%)}	_{15.65s (± 0.31%)}	_~	_15.57s	_15.71s	_{p=0.469 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.01s (± 0.28%)}	_{19.99s (± 0.30%)}	_~	_19.90s	_20.07s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,990,754	_2,990,754	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,029,099	_1,029,099	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,115,966k (± 0.00%)}	_{3,115,936k (± 0.00%)}	_~	_3,115,873k	_3,116,073k	_{p=0.230 n=6}
_{Parse Time}	_{16.95s (± 0.30%)}	_{16.97s (± 0.52%)}	_~	_16.82s	_17.08s	_{p=0.470 n=6}
_{Bind Time}	_{5.30s (± 2.62%)}	_{5.23s (± 1.88%)}	_~	_5.17s	_5.43s	_{p=1.000 n=6}
_{Check Time}	_{95.82s (± 0.50%)}	_{95.42s (± 0.27%)}	_~	_95.17s	_95.86s	_{p=0.128 n=6}
_{Emit Time}	_{24.95s (± 0.48%)}	_{24.92s (± 0.35%)}	_~	_24.78s	_25.03s	_{p=0.686 n=6}
_{Total Time}	_{143.03s (± 0.29%)}	_{142.53s (± 0.20%)}	_{-0.49s (- 0.34%)}	_142.05s	_142.85s	_{p=0.045 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,972	_267,972	_~	_~	_~	_{p=1.000 n=6}
_Types	_109,178	_109,178	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{412,926k (± 0.01%)}	_{412,908k (± 0.01%)}	_~	_412,837k	_412,959k	_{p=0.575 n=6}
_{Parse Time}	_{3.17s (± 0.65%)}	_{3.19s (± 0.33%)}	_~	_3.17s	_3.20s	_{p=0.141 n=6}
_{Bind Time}	_{1.43s (± 0.77%)}	_{1.43s (± 0.57%)}	_~	_1.42s	_1.44s	_{p=0.448 n=6}
_{Check Time}	_{14.37s (± 0.39%)}	_{14.36s (± 0.14%)}	_~	_14.33s	_14.38s	_{p=0.334 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.97s (± 0.32%)}	_{18.98s (± 0.14%)}	_~	_18.93s	_19.00s	_{p=0.936 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_538,543	_538,543	_~	_~	_~	_{p=1.000 n=6}
_Types	_176,469	_176,469	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{481,362k (± 0.01%)}	_{481,358k (± 0.01%)}	_~	_481,296k	_481,421k	_{p=0.936 n=6}
_{Parse Time}	_{2.83s (± 0.66%)}	_{2.83s (± 0.47%)}	_~	_2.81s	_2.84s	_{p=0.359 n=6}
_{Bind Time}	_{1.05s (± 0.72%)}	_{1.05s (± 0.78%)}	_~	_1.03s	_1.05s	_{p=1.000 n=6}
_{Check Time}	_{15.26s (± 0.30%)}	_{15.24s (± 0.22%)}	_~	_15.19s	_15.29s	_{p=0.421 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.14s (± 0.31%)}	_{19.12s (± 0.21%)}	_~	_19.08s	_19.18s	_{p=0.517 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-08-02T09:58:59Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59510/merge:

Everything looks good!

weswigham

Needs a merge conflict resolved before it can be merged - but I'm starting to think it'd be nice to pull sameMap(signature.typeParameters!, tp => tp.mapper ? instantiateType(tp, tp.mapper) : tp) into a helper function like getTypeParametersForMapper(signature) for the two locations we use it (an inference context is a type mapper).

…ure-instantiation-with-default-type-arg

Andarist · 2024-08-07T11:02:27Z

done and done :)

jakebailey · 2024-08-09T03:17:02Z

@typescript-bot cherry-pick to release-5.5

This is the same fix as #59121 which we also backported to 5.5.

typescript-bot · 2024-08-09T03:17:05Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick to release-5.5`	✅ Started	✅ Results

typescript-bot · 2024-08-09T03:19:32Z

Hey, @jakebailey! I've created #59570 for you.

Fixed regression in generic signature instantiation with default type…

ee5ecfa

… args

typescript-bot assigned weswigham Aug 2, 2024

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Aug 2, 2024

weswigham approved these changes Aug 6, 2024

View reviewed changes

Andarist added 2 commits August 7, 2024 12:57

Merge remote-tracking branch 'origin/main' into fix/regression-signat…

549ba36

…ure-instantiation-with-default-type-arg

introduce helper

c21266a

jakebailey approved these changes Aug 8, 2024

View reviewed changes

typescript-bot mentioned this pull request Aug 9, 2024

🤖 Pick PR #59510 (Fixed regression in generic signatu...) into release-5.5 #59570

Closed

jakebailey merged commit 1bb1d2a into microsoft:main Aug 9, 2024

sandersn removed this from PR Backlog Apr 22, 2025

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed regression in generic signature instantiation with default type args#59510

Fixed regression in generic signature instantiation with default type args#59510
jakebailey merged 3 commits intomicrosoft:mainfrom
Andarist:fix/regression-signature-instantiation-with-default-type-arg

Andarist commented Aug 2, 2024

Uh oh!

jakebailey commented Aug 2, 2024

Uh oh!

typescript-bot commented Aug 2, 2024 •

edited

Loading

Uh oh!

typescript-bot commented Aug 2, 2024

Uh oh!

typescript-bot commented Aug 2, 2024

Uh oh!

typescript-bot commented Aug 2, 2024

tsc

Uh oh!

typescript-bot commented Aug 2, 2024

Uh oh!

weswigham left a comment

Uh oh!

Andarist commented Aug 7, 2024

Uh oh!

jakebailey commented Aug 9, 2024

Uh oh!

typescript-bot commented Aug 9, 2024 •

edited

Loading

Uh oh!

typescript-bot commented Aug 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Andarist commented Aug 2, 2024

Uh oh!

jakebailey commented Aug 2, 2024

Uh oh!

typescript-bot commented Aug 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 2, 2024

Uh oh!

typescript-bot commented Aug 2, 2024

Uh oh!

typescript-bot commented Aug 2, 2024

tsc

Uh oh!

typescript-bot commented Aug 2, 2024

Uh oh!

weswigham left a comment

Choose a reason for hiding this comment

Uh oh!

Andarist commented Aug 7, 2024

Uh oh!

jakebailey commented Aug 9, 2024

Uh oh!

typescript-bot commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

typescript-bot commented Aug 2, 2024 •

edited

Loading

typescript-bot commented Aug 9, 2024 •

edited

Loading