fix: filtering promise properties in object literal completion#59316
fix: filtering promise properties in object literal completion#59316jakebailey merged 7 commits intomicrosoft:mainfrom
Conversation
|
Tests for completions can be written like this: |
99ef608 to
63999d3
Compare
089a830 to
3e8aafd
Compare
3e8aafd to
be95930
Compare
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
be95930 to
994cc76
Compare
|
This looks good to me, though #59316 was accepted without determining whether or not the items should be prioritized or filtered, and this PR filters them out entirely. I assume that ordering them is going to be a challenge, so are we okay with not providing promise-like method completions here? |
|
@typescript-bot pack this |
|
Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
screenshot
In the actual development environment, it was possible to reproduce what was solved.But I can't find a case to write a test. Can someone give me an idea?Fixes #59298