Fixed an accidental `undefined` leak into `getAccessibleSymbolChain`'s cache key by Andarist · Pull Request #58669 · microsoft/TypeScript

Andarist · 2024-05-27T09:25:17Z

No description provided.

…s cache key

typescript-bot · 2024-05-27T09:25:21Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Andarist · 2024-05-27T09:27:12Z

src/compiler/checker.ts

        // Go from enclosingDeclaration to the first scope we check, so the cache is keyed off the scope and thus shared more
        const firstRelevantLocation = forEachSymbolTableInScope(enclosingDeclaration, (_, __, ___, node) => node);
-        const key = `${useOnlyExternalAliasing ? 0 : 1}|${firstRelevantLocation && getNodeId(firstRelevantLocation)}|${meaning}`;
+        const key = `${useOnlyExternalAliasing ? 0 : 1}|${firstRelevantLocation ? getNodeId(firstRelevantLocation) : 0}|${meaning}`;


I noticed that those keys could look smth like '0|undefined|788968' (I spotted an instance of that in the debugger). It bugged me enough to create this PR ;p

0 should be a safe fallback here as the lowest possible node id is 1

jakebailey · 2024-10-31T19:32:08Z

@typescript-bot test it

Double checking this isn't depended on accidentally.

typescript-bot · 2024-10-31T19:32:12Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-10-31T19:54:44Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-10-31T19:54:56Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/58669/merge:

Everything looks good!

typescript-bot · 2024-10-31T20:14:17Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,617k (± 1.03%)}	_{192,795k (± 0.01%)}	_~	_192,777k	_192,808k	_{p=0.229 n=6}
_{Parse Time}	_{1.31s (± 1.12%)}	_{1.31s (± 0.62%)}	_~	_1.30s	_1.32s	_{p=1.000 n=6}
_{Bind Time}	_{0.72s (± 0.57%)}	_0.72s	_~	_~	_~	_{p=0.405 n=6}
_{Check Time}	_{9.74s (± 0.35%)}	_{9.75s (± 0.26%)}	_~	_9.72s	_9.79s	_{p=0.419 n=6}
_{Emit Time}	_{2.71s (± 1.39%)}	_{2.71s (± 1.27%)}	_~	_2.64s	_2.73s	_{p=0.687 n=6}
_{Total Time}	_{14.48s (± 0.38%)}	_{14.49s (± 0.34%)}	_~	_14.40s	_14.55s	_{p=0.742 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,886	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,604k (± 0.00%)}	_{1,224,610k (± 0.00%)}	_~	_1,224,562k	_1,224,679k	_{p=0.748 n=6}
_{Parse Time}	_{6.64s (± 0.73%)}	_{6.65s (± 0.61%)}	_~	_6.61s	_6.72s	_{p=0.687 n=6}
_{Bind Time}	_{1.89s (± 0.29%)}	_{1.88s (± 0.27%)}	_~	_1.88s	_1.89s	_{p=0.640 n=6}
_{Check Time}	_{31.88s (± 0.48%)}	_{31.87s (± 0.33%)}	_~	_31.70s	_31.99s	_{p=0.810 n=6}
_{Emit Time}	_{15.23s (± 0.43%)}	_{15.22s (± 0.40%)}	_~	_15.15s	_15.31s	_{p=1.000 n=6}
_{Total Time}	_{55.63s (± 0.22%)}	_{55.63s (± 0.30%)}	_~	_55.40s	_55.82s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,495,026	_2,495,026	_~	_~	_~	_{p=1.000 n=6}
_Types	_908,645	_908,645	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,307,184k (± 0.00%)}	_{2,307,204k (± 0.00%)}	_~	_2,307,173k	_2,307,233k	_{p=0.378 n=6}
_{Parse Time}	_{9.32s (± 0.25%)}	_{9.31s (± 0.20%)}	_~	_9.28s	_9.33s	_{p=0.683 n=6}
_{Bind Time}	_{2.14s (± 0.39%)}	_{2.14s (± 0.19%)}	_~	_2.13s	_2.14s	_{p=0.527 n=6}
_{Check Time}	_{75.07s (± 0.57%)}	_{75.20s (± 0.43%)}	_~	_74.75s	_75.65s	_{p=0.689 n=6}
_{Emit Time}	_0.28s	_{0.28s (± 1.47%)}	_~	_0.27s	_0.28s	_{p=0.405 n=6}
_{Total Time}	_{86.81s (± 0.49%)}	_{86.93s (± 0.38%)}	_~	_86.49s	_87.39s	_{p=0.748 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,087	_1,258,087	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,235	_266,235	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,422,687k (± 0.03%)}	_{2,422,754k (± 0.01%)}	_~	_2,422,385k	_2,423,074k	_{p=0.689 n=6}
_{Parse Time}	_{5.20s (± 0.77%)}	_{5.20s (± 0.86%)}	_~	_5.14s	_5.28s	_{p=1.000 n=6}
_{Bind Time}	_{1.93s (± 0.61%)}	_{1.92s (± 0.63%)}	_~	_1.91s	_1.94s	_{p=0.618 n=6}
_{Check Time}	_{35.47s (± 0.42%)}	_{35.46s (± 0.26%)}	_~	_35.37s	_35.60s	_{p=0.936 n=6}
_{Emit Time}	_{3.00s (± 1.37%)}	_{3.07s (± 4.20%)}	_~	_2.99s	_3.33s	_{p=0.336 n=6}
_{Total Time}	_{45.60s (± 0.37%)}	_{45.66s (± 0.30%)}	_~	_45.48s	_45.83s	_{p=0.378 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,087	_1,258,087	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,235	_266,235	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,620,075k (±11.19%)}	_{2,526,611k (± 2.55%)}	_~	_2,498,240k	_2,658,108k	_{p=0.810 n=6}
_{Parse Time}	_{6.61s (± 2.71%)}	_{6.59s (± 0.89%)}	_~	_6.52s	_6.68s	_{p=0.521 n=6}
_{Bind Time}	_{2.17s (± 0.35%)}	_{2.17s (± 1.07%)}	_~	_2.14s	_2.20s	_{p=0.628 n=6}
_{Check Time}	_{43.14s (± 0.23%)}	_{43.20s (± 0.70%)}	_~	_42.69s	_43.44s	_{p=0.336 n=6}
_{Emit Time}	_{3.58s (± 5.64%)}	_{3.52s (± 6.45%)}	_~	_3.34s	_3.97s	_{p=0.297 n=6}
_{Total Time}	_{55.49s (± 0.58%)}	_{55.51s (± 0.72%)}	_~	_55.03s	_56.22s	_{p=0.688 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,754	_261,754	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,477	_106,477	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{438,832k (± 0.01%)}	_{438,858k (± 0.01%)}	_~	_438,785k	_438,905k	_{p=0.298 n=6}
_{Parse Time}	_{3.54s (± 0.58%)}	_{3.53s (± 0.72%)}	_~	_3.49s	_3.56s	_{p=0.416 n=6}
_{Bind Time}	_{1.31s (± 1.31%)}	_{1.32s (± 0.75%)}	_~	_1.31s	_1.33s	_{p=0.673 n=6}
_{Check Time}	_{19.00s (± 0.41%)}	_{18.95s (± 0.26%)}	_~	_18.89s	_19.01s	_{p=0.199 n=6}
_{Emit Time}	_{1.53s (± 0.89%)}	_{1.54s (± 1.54%)}	_~	_1.50s	_1.57s	_{p=0.459 n=6}
_{Total Time}	_{25.39s (± 0.32%)}	_{25.34s (± 0.24%)}	_~	_25.24s	_25.42s	_{p=0.332 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,919	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,075k (± 0.01%)}	_{371,041k (± 0.01%)}	_~	_370,998k	_371,076k	_{p=0.093 n=6}
_{Parse Time}	_{2.90s (± 1.21%)}	_{2.91s (± 0.60%)}	_~	_2.88s	_2.93s	_{p=0.747 n=6}
_{Bind Time}	_{1.59s (± 0.69%)}	_{1.60s (± 2.36%)}	_~	_1.55s	_1.64s	_{p=0.935 n=6}
_{Check Time}	_{16.39s (± 0.21%)}	_{16.40s (± 0.32%)}	_~	_16.34s	_16.47s	_{p=0.687 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.88s (± 0.30%)}	_{20.91s (± 0.37%)}	_~	_20.78s	_20.98s	_{p=0.422 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,130,033	_3,130,033	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,079,008	_1,079,008	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,219,013k (± 0.01%)}	_{3,219,240k (± 0.01%)}	_~	_3,218,627k	_3,219,475k	_{p=0.230 n=6}
_{Parse Time}	_{14.01s (± 0.25%)}	_{14.03s (± 0.63%)}	_~	_13.95s	_14.15s	_{p=0.678 n=6}
_{Bind Time}	_{4.47s (± 2.09%)}	_{4.54s (± 2.68%)}	_~	_4.43s	_4.68s	_{p=0.744 n=6}
_{Check Time}	_{86.18s (± 1.85%)}	_{86.72s (± 3.23%)}	_~	_84.20s	_91.42s	_{p=1.000 n=6}
_{Emit Time}	_{25.80s (± 6.80%)}	_{25.29s (± 8.65%)}	_~	_22.52s	_27.17s	_{p=0.810 n=6}
_{Total Time}	_{130.46s (± 2.31%)}	_{130.58s (± 2.92%)}	_~	_126.16s	_136.98s	_{p=1.000 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_287,028	_287,028	_~	_~	_~	_{p=1.000 n=6}
_Types	_116,316	_116,316	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{438,455k (± 0.02%)}	_{438,358k (± 0.02%)}	_~	_438,281k	_438,441k	_{p=0.128 n=6}
_{Parse Time}	_{4.07s (± 0.71%)}	_{4.07s (± 0.50%)}	_~	_4.04s	_4.09s	_{p=0.870 n=6}
_{Bind Time}	_{1.75s (± 0.59%)}	_{1.75s (± 1.64%)}	_~	_1.71s	_1.79s	_{p=0.739 n=6}
_{Check Time}	_{18.55s (± 0.45%)}	_{18.50s (± 0.37%)}	_~	_18.37s	_18.55s	_{p=0.260 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.36s (± 0.36%)}	_{24.33s (± 0.25%)}	_~	_24.22s	_24.39s	_{p=0.298 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_543,130	_543,130	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,889	_181,889	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{485,535k (± 0.01%)}	_{485,527k (± 0.01%)}	_~	_485,464k	_485,609k	_{p=0.810 n=6}
_{Parse Time}	_{4.17s (± 0.52%)}	_{4.17s (± 0.54%)}	_~	_4.15s	_4.21s	_{p=1.000 n=6}
_{Bind Time}	_{1.46s (± 1.18%)}	_{1.47s (± 0.61%)}	_~	_1.46s	_1.48s	_{p=0.215 n=6}
_{Check Time}	_{23.73s (± 0.35%)}	_{23.71s (± 0.52%)}	_~	_23.59s	_23.91s	_{p=0.748 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{29.36s (± 0.25%)}	_{29.35s (± 0.42%)}	_~	_29.22s	_29.54s	_{p=0.748 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-10-31T21:11:02Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/58669/merge:

Everything looks good!

Fixed an accidental undefined leak into getAccessibleSymbolChain'…

1a1c6dd

…s cache key

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 27, 2024

Andarist commented May 27, 2024

View reviewed changes

jakebailey approved these changes Oct 31, 2024

View reviewed changes

jakebailey merged commit 32513a7 into microsoft:main Oct 31, 2024

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed an accidental `undefined` leak into `getAccessibleSymbolChain`'s cache key#58669

Fixed an accidental `undefined` leak into `getAccessibleSymbolChain`'s cache key#58669
jakebailey merged 1 commit intomicrosoft:mainfrom
Andarist:fix/accidental-undefined-in-cache-key

Andarist commented May 27, 2024

Uh oh!

typescript-bot commented May 27, 2024

Uh oh!

Andarist May 27, 2024

Uh oh!

jakebailey commented Oct 31, 2024

Uh oh!

typescript-bot commented Oct 31, 2024 •

edited

Loading

Uh oh!

typescript-bot commented Oct 31, 2024

Uh oh!

typescript-bot commented Oct 31, 2024

Uh oh!

typescript-bot commented Oct 31, 2024

tsc

Uh oh!

typescript-bot commented Oct 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

Andarist commented May 27, 2024

Uh oh!

typescript-bot commented May 27, 2024

Uh oh!

Andarist May 27, 2024

Choose a reason for hiding this comment

Uh oh!

jakebailey commented Oct 31, 2024

Uh oh!

typescript-bot commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 31, 2024

Uh oh!

typescript-bot commented Oct 31, 2024

Uh oh!

typescript-bot commented Oct 31, 2024

tsc

Uh oh!

typescript-bot commented Oct 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

typescript-bot commented Oct 31, 2024 •

edited

Loading