Fixed na issue with evaluator using binding element initializers as const values#55910
Merged
jakebailey merged 3 commits intomicrosoft:mainfrom Sep 29, 2023
Merged
Conversation
typescript-bot
added
the
For Uncommitted Bug
Andarist
commented
Sep 29, 2023
src/compiler/checker.ts
Outdated
| if (isConstantVariable(symbol)) { | ||
| const declaration = symbol.valueDeclaration as VariableDeclaration | undefined; | ||
| if (declaration && !declaration.type && declaration.initializer && (!location || declaration !== location && isBlockScopedNameDeclaredBeforeUse(declaration, location))) { | ||
| if (declaration?.kind === SyntaxKind.VariableDeclaration && !declaration.type && declaration.initializer && (!location || declaration !== location && isBlockScopedNameDeclaredBeforeUse(declaration, location))) { |
Contributor
Author
There was a problem hiding this comment.
alternatively, I could check if the parent is not a BindingElement
Member
There was a problem hiding this comment.
Would that break on parameters? I guess not, since isConstantVariable won't be true.
Member
There was a problem hiding this comment.
I'll also note that this feels weird because declaration is VariableDeclaration which must have kind === SyntaxKind.VariableDeclaration.
Contributor
Author
There was a problem hiding this comment.
I'll also note that this feels weird because declaration is VariableDeclaration which must have kind === SyntaxKind.VariableDeclaration.
Good catch! I didn't notice it. It is VariableDeclaration just because of the cast - so I'll make that cast more accurate in a second :)
Member
|
@typescript-bot test top100 |
Collaborator
|
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 8cd9111. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @jakebailey, I've started to run the regular perf test suite on this PR at 8cd9111. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 8cd9111. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 8cd9111. You can monitor the build here. Update: The results are in! |
Collaborator
|
@jakebailey Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Everything looks good! |
Collaborator
|
@jakebailey Here they are:
CompilerComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
StartupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Collaborator
|
@jakebailey Here are the results of running the top-repos suite comparing Everything looks good! |
jakebailey
approved these changes
Sep 29, 2023
Collaborator
|
Hey @jakebailey, the results of running the DT tests are ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #55907