Defer index types on remapping mapped types by Andarist · Pull Request #55140 · microsoft/TypeScript

Andarist · 2023-07-24T20:28:58Z

Andarist · 2023-07-24T20:44:48Z

src/compiler/checker.ts

        const objectType = (type as IndexedAccessType).objectType;
        const indexType = (type as IndexedAccessType).indexType;
-        if (isTypeAssignableTo(indexType, getIndexType(objectType, IndexFlags.None))) {
+        if (isTypeAssignableTo(indexType, getIndexType(objectType, IndexFlags.NoRemappingMappedTypeDeferral))) {


I kinda expected that I would have to pass this at more locations. Given the fact that this is the only call site using this... maybe I just should remove this IndexFlags.NoRemappingMappedTypeDeferral and perform the targeted simplification of keyof RemappingMappedType here to pass it to the isTypeAssignableTo.

That would probably be better - IndexFlags originally only existed to support the keyofStringsOnly flag, and its' other uses have kind of become a convenience. With keyofStringsOnly likely to go away soonish, it'd be nice if we could stop having all these quiet variant index types.

pushed out this change

weswigham · 2023-08-14T20:27:19Z

src/compiler/checker.ts

        const objectType = (type as IndexedAccessType).objectType;
        const indexType = (type as IndexedAccessType).indexType;
-        if (isTypeAssignableTo(indexType, getIndexType(objectType, IndexFlags.None))) {
+        if (isTypeAssignableTo(indexType, getIndexType(objectType, IndexFlags.NoRemappingMappedTypeDeferral))) {


That would probably be better - IndexFlags originally only existed to support the keyofStringsOnly flag, and its' other uses have kind of become a convenience. With keyofStringsOnly likely to go away soonish, it'd be nice if we could stop having all these quiet variant index types.

weswigham · 2023-08-14T20:29:12Z

src/compiler/checker.ts

+const enum MappedTypeNameTypeKind {
+    None = 0,
+    Filtering = 1 << 0,
+    Remapping = 1 << 1,


Why is this a flags enum? I can't see anywhere we actually combine multiple flags - in fact, it seems to me like a mapped type can only be one, given the implementation of getMappedTypeNameTypeKind.

I had some composite values here before but removed them at the end since I didn't actually use them anywhere. Refactored this now to be a non-flag enum

…-on-remapping-mapped-types

weswigham · 2023-09-13T19:10:19Z

@typescript-bot test this
@typescript-bot run dt
@typescript-bot test top100
@typescript-bot perf test this

typescript-bot · 2023-09-13T19:10:21Z

Heya @weswigham, I've started to run the regular perf test suite on this PR at 9f95520. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-13T19:10:21Z

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 9f95520. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-13T19:10:21Z

Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at 9f95520. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-13T20:15:05Z

@weswigham
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{300,275k (± 0.01%)}	_{300,270k (± 0.01%)}	_~	_300,247k	_300,307k	_{p=0.873 n=6}
_{Parse Time}	_{3.01s (± 0.28%)}	_{3.01s (± 0.14%)}	_~	_3.00s	_3.01s	_{p=0.285 n=6}
_{Bind Time}	_{0.93s (± 0.00%)}	_{0.93s (± 0.44%)}	_~	_0.93s	_0.94s	_{p=0.405 n=6}
_{Check Time}	_{9.34s (± 0.34%)}	_{9.31s (± 0.30%)}	_~	_9.28s	_9.35s	_{p=0.075 n=6}
_{Emit Time}	_{7.64s (± 0.27%)}	_{7.63s (± 0.24%)}	_~	_7.61s	_7.66s	_{p=0.626 n=6}
_{Total Time}	_{20.92s (± 0.20%)}	_{20.88s (± 0.15%)}	_~	_20.84s	_20.92s	_{p=0.106 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,951k (± 0.02%)}	_{193,959k (± 0.02%)}	_~	_193,931k	_194,001k	_{p=0.810 n=6}
_{Parse Time}	_{1.58s (± 0.00%)}	_{1.58s (± 0.00%)}	_~	_1.58s	_1.58s	_{p=1.000 n=6}
_{Bind Time}	_{0.80s (± 0.65%)}	_{0.80s (± 0.65%)}	_~	_0.79s	_0.80s	_{p=1.000 n=6}
_{Check Time}	_{9.93s (± 0.31%)}	_{9.94s (± 0.28%)}	_~	_9.91s	_9.98s	_{p=0.809 n=6}
_{Emit Time}	_{2.74s (± 0.27%)}	_{2.74s (± 0.15%)}	_~	_2.73s	_2.74s	_{p=0.389 n=6}
_{Total Time}	_{15.05s (± 0.23%)}	_{15.06s (± 0.20%)}	_~	_15.03s	_15.10s	_{p=0.809 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{347,197k (± 0.01%)}	_{347,190k (± 0.01%)}	_~	_347,156k	_347,219k	_{p=0.470 n=6}
_{Parse Time}	_{2.69s (± 0.19%)}	_{2.69s (± 0.20%)}	_~	_2.68s	_2.69s	_{p=0.640 n=6}
_{Bind Time}	_{0.99s (± 0.00%)}	_{0.99s (± 0.41%)}	_~	_0.98s	_0.99s	_{p=0.405 n=6}
_{Check Time}	_{7.93s (± 0.10%)}	_{7.94s (± 0.26%)}	_~	_7.92s	_7.97s	_{p=0.557 n=6}
_{Emit Time}	_{4.27s (± 0.32%)}	_{4.27s (± 0.24%)}	_~	_4.25s	_4.28s	_{p=0.867 n=6}
_{Total Time}	_{15.88s (± 0.11%)}	_{15.88s (± 0.16%)}	_~	_15.85s	_15.92s	_{p=0.871 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{301,179k (± 0.00%)}	_{301,190k (± 0.00%)}	_~	_301,176k	_301,205k	_{p=0.199 n=6}
_{Parse Time}	_{2.17s (± 0.56%)}	_{2.17s (± 0.61%)}	_~	_2.15s	_2.18s	_{p=0.652 n=6}
_{Bind Time}	_{1.11s (± 0.00%)}	_{1.11s (± 0.37%)}	_~	_1.11s	_1.12s	_{p=0.405 n=6}
_{Check Time}	_{7.23s (± 0.21%)}	_{7.23s (± 0.17%)}	_~	_7.22s	_7.25s	_{p=0.327 n=6}
_{Emit Time}	_{3.99s (± 0.43%)}	_{3.98s (± 0.32%)}	_~	_3.96s	_3.99s	_{p=0.359 n=6}
_{Total Time}	_{14.50s (± 0.13%)}	_{14.50s (± 0.17%)}	_~	_14.46s	_14.52s	_{p=1.000 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{479,542k (± 0.00%)}	_{479,534k (± 0.00%)}	_~	_479,522k	_479,541k	_{p=0.521 n=6}
_{Parse Time}	_{3.15s (± 0.16%)}	_{3.16s (± 0.20%)}	_{+0.01s (+ 0.42%)}	_3.15s	_3.17s	_{p=0.009 n=6}
_{Bind Time}	_{0.91s (± 0.00%)}	_{0.91s (± 0.00%)}	_~	_0.91s	_0.91s	_{p=1.000 n=6}
_{Check Time}	_{17.86s (± 0.27%)}	_{17.93s (± 0.40%)}	_~	_17.82s	_18.02s	_{p=0.106 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.92s (± 0.23%)}	_{21.99s (± 0.34%)}	_~	_21.89s	_22.10s	_{p=0.090 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{542,941k (± 0.01%)}	_{542,872k (± 0.01%)}	_~	_542,806k	_542,930k	_{p=0.128 n=6}
_{Parse Time}	_{3.69s (± 0.33%)}	_{3.69s (± 0.20%)}	_~	_3.68s	_3.70s	_{p=0.867 n=6}
_{Bind Time}	_{1.42s (± 4.50%)}	_{1.44s (± 3.69%)}	_~	_1.33s	_1.46s	_{p=0.440 n=6}
_{Check Time}	_{3.23s (± 2.96%)}	_{3.19s (± 2.23%)}	_~	_3.15s	_3.33s	_{p=0.060 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.09s (± 6.44%)}	_~	_0.08s	_0.09s	_{p=0.282 n=6}
_{Total Time}	_{8.43s (± 0.45%)}	_{8.40s (± 0.31%)}	_~	_8.37s	_8.45s	_{p=0.347 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,491ms (± 0.07%)}	_{2,491ms (± 0.11%)}	_~	_2,488ms	_2,494ms	_{p=0.934 n=6}
_{Req 2 - geterr}	_{5,942ms (± 0.36%)}	_{5,942ms (± 0.26%)}	_~	_5,914ms	_5,959ms	_{p=1.000 n=6}
_{Req 3 - references}	_{342ms (± 0.22%)}	_{343ms (± 0.40%)}	_~	_342ms	_346ms	_{p=0.081 n=6}
_{Req 4 - navto}	_{275ms (± 0.37%)}	_{276ms (± 0.20%)}	_~	_275ms	_276ms	_{p=0.663 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (± 3.97%)}	_{78ms (± 3.32%)}	_~	_76ms	_81ms	_{p=0.774 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,615ms (± 0.48%)}	_{2,618ms (± 0.46%)}	_~	_2,606ms	_2,638ms	_{p=0.572 n=6}
_{Req 2 - geterr}	_{4,781ms (± 0.18%)}	_{4,780ms (± 0.15%)}	_~	_4,772ms	_4,788ms	_{p=0.936 n=6}
_{Req 3 - references}	_{350ms (± 0.28%)}	_{351ms (± 0.23%)}	_~	_350ms	_352ms	_{p=0.282 n=6}
_{Req 4 - navto}	_{269ms (± 0.20%)}	_{271ms (± 1.51%)}	_~	_266ms	_276ms	_{p=0.371 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 0.80%)}	_{79ms (± 0.65%)}	_~	_79ms	_80ms	_{p=0.386 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,705ms (± 0.28%)}	_{2,710ms (± 0.17%)}	_~	_2,704ms	_2,716ms	_{p=0.199 n=6}
_{Req 2 - geterr}	_{1,964ms (± 2.56%)}	_{1,951ms (± 2.02%)}	_~	_1,900ms	_1,981ms	_{p=0.296 n=6}
_{Req 3 - references}	_{133ms (± 8.56%)}	_{137ms (± 1.94%)}	_~	_134ms	_140ms	_{p=0.466 n=6}
_{Req 4 - navto}	_{359ms (± 0.99%)}	_{358ms (± 0.76%)}	_~	_355ms	_362ms	_{p=0.517 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{328ms (± 1.05%)}	_{321ms (± 1.66%)}	_~	_317ms	_331ms	_{p=0.091 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

CompilerTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
xstateTSServer - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{156.22ms (± 0.16%)}	_{156.53ms (± 0.18%)}	_{+0.31ms (+ 0.20%)}	_154.58ms	_159.01ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{231.16ms (± 0.15%)}	_{231.86ms (± 0.13%)}	_{+0.71ms (+ 0.31%)}	_230.35ms	_234.83ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{235.57ms (± 0.12%)}	_{236.08ms (± 0.12%)}	_{+0.50ms (+ 0.21%)}	_234.77ms	_240.01ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{235.64ms (± 0.12%)}	_{235.61ms (± 0.11%)}	_~	_234.33ms	_239.65ms	_{p=0.393 n=600}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-09-13T20:20:02Z

@weswigham Here are the results of running the top-repos suite comparing main and refs/pull/55140/merge:

Everything looks good!

typescript-bot · 2023-09-13T20:39:50Z

Hey @weswigham, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

sandersn · 2023-11-30T15:04:50Z

@typescript-bot run dt

typescript-bot · 2023-11-30T15:04:57Z

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at 847cb6d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-30T15:50:52Z

Hey @sandersn, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

Andarist added 2 commits July 24, 2023 22:09

Defer index types on remapping mapped types

a59d618

Introduce MappedTypeNameTypeKind

b4593fd

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 24, 2023

Andarist commented Jul 24, 2023

View reviewed changes

sandersn requested a review from ahejlsberg August 11, 2023 23:06

typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 11, 2023

sandersn requested a review from weswigham August 11, 2023 23:06

sandersn assigned ahejlsberg Aug 11, 2023

weswigham requested changes Aug 14, 2023

View reviewed changes

Andarist added 4 commits August 14, 2023 22:38

Merge remote-tracking branch 'origin/main' into fix/defer-index-types…

8407df6

…-on-remapping-mapped-types

Merge remote-tracking branch 'origin/main' into fix/defer-index-types…

f7c7417

…-on-remapping-mapped-types

Replace NoRemappingMappedTypeDeferral with targeted simplification

f6b0c86

Make MappedTypeNameTypeKind non-flag enum

9c88462

Andarist requested a review from weswigham August 14, 2023 21:08

Merge remote-tracking branch 'origin/main' into fix/defer-index-types…

9f95520

…-on-remapping-mapped-types

weswigham approved these changes Sep 13, 2023

View reviewed changes

Merge branch 'main' into fix/defer-index-types-on-remapping-mapped-types

847cb6d

sandersn merged commit 2c4cbd9 into microsoft:main Nov 30, 2023

Andarist deleted the fix/defer-index-types-on-remapping-mapped-types branch November 11, 2024 19:15

This was referenced Nov 11, 2024

Regression: Mapped type with recursive key remapping crashes tsc with "RangeError: Maximum call stack size exceeded" in TS@5.4+ #60476

Closed

Fixed crash related to index type deferral on generic mapped types with name types #60528

Merged

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Comments

Conversation

Andarist commented Jul 24, 2023

Uh oh!

Andarist Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

weswigham Aug 14, 2023

Choose a reason for hiding this comment

Uh oh!

Andarist Aug 14, 2023

Choose a reason for hiding this comment

Uh oh!

weswigham Aug 14, 2023

Choose a reason for hiding this comment

Uh oh!

weswigham Aug 14, 2023

Choose a reason for hiding this comment

Uh oh!

Andarist Aug 14, 2023

Choose a reason for hiding this comment

Uh oh!

weswigham commented Sep 13, 2023

Uh oh!

typescript-bot commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 13, 2023

Compiler

tsserver

Startup

Uh oh!

typescript-bot commented Sep 13, 2023

Uh oh!

typescript-bot commented Sep 13, 2023

Uh oh!

sandersn commented Nov 30, 2023

Uh oh!

typescript-bot commented Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Nov 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

typescript-bot commented Sep 13, 2023 •

edited

Loading

typescript-bot commented Sep 13, 2023 •

edited

Loading

typescript-bot commented Sep 13, 2023 •

edited

Loading

typescript-bot commented Nov 30, 2023 •

edited

Loading