DOM update 2023/06/21 by sandersn · Pull Request #54725 · microsoft/TypeScript

sandersn · 2023-06-21T15:59:43Z

DOM update 2023/06/21

Adds canParse to URL.
Adds a fairly large and precise string union AutoFill generated by a number of template type literals. Used for many autocomplete properties.
Adds Web Transport types.
Adds popover support.
Adds ToggleEvent.
URLSearchParams adds size and delete/has adds optional second parameter.
WASM's Global interface adds a type parameter T extends ValueType = ValueType, used to type value/valueOf. (type ValueType = "anyfunc" | "externref" | "f32" | "f64" | "i32" | "i64" | "v128")

The only suspicious changes I see are (2) and (7); the former because it might be slow, the latter because I don't understand what Global is for, and adding a type parameter in the DOM has gone badly in the past.

Fixes #54280

sandersn · 2023-06-21T16:21:31Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2023-06-21T16:21:34Z

Heya @sandersn, I've started to run the diff-based user code test suite on this PR at 6cdba31. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-21T16:21:34Z

Heya @sandersn, I've started to run the diff-based top-repos suite on this PR at 6cdba31. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-21T16:21:34Z

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at 6cdba31. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-21T16:21:34Z

Heya @sandersn, I've started to run the perf test suite on this PR at 6cdba31. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-21T16:21:34Z

Heya @sandersn, I've started to run the diff-based user code test suite (tsserver) on this PR at 6cdba31. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-21T16:21:34Z

Heya @sandersn, I've started to run the extended test suite on this PR at 6cdba31. You can monitor the build here.

typescript-bot · 2023-06-21T16:21:34Z

Heya @sandersn, I've started to run the diff-based top-repos suite (tsserver) on this PR at 6cdba31. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-21T16:42:10Z

@sandersn Here are the results of running the user test suite comparing main and refs/pull/54725/merge:

Everything looks good!

typescript-bot · 2023-06-21T16:53:44Z

@sandersn Here are the results of running the user test suite comparing main and refs/pull/54725/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

[NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-54725/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54725/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54725/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-54725/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54725/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54725/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-54725/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54725/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54725/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-54725/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54725/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54725/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-54725/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54725/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54725/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
[MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

typescript-bot · 2023-06-21T17:18:12Z

@sandersn
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..54725

_Metric	_main	₅₄₇₂₅	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{366,151k (± 0.01%)}	_{366,409k (± 0.01%)}	_{+257k (+ 0.07%)}	_366,368k	_366,464k	_{p=0.005 n=6}
_{Parse Time}	_{3.41s (± 0.12%)}	_{3.44s (± 0.78%)}	_{+0.03s (+ 0.83%)}	_3.42s	_3.49s	_{p=0.006 n=6}
_{Bind Time}	_{1.12s (± 0.46%)}	_{1.12s (± 0.73%)}	_~	_1.10s	_1.12s	_{p=0.752 n=6}
_{Check Time}	_{8.81s (± 0.30%)}	_{8.81s (± 0.43%)}	_~	_8.77s	_8.86s	_{p=0.870 n=6}
_{Emit Time}	_{7.44s (± 0.52%)}	_{7.46s (± 0.50%)}	_~	_7.41s	_7.51s	_{p=0.570 n=6}
_{Total Time}	_{20.77s (± 0.26%)}	_{20.83s (± 0.40%)}	_~	_20.71s	_20.91s	_{p=0.172 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{191,738k (± 1.20%)}	_{193,711k (± 1.61%)}	_~	_190,829k	_196,677k	_{p=0.093 n=6}
_{Parse Time}	_{1.50s (± 1.63%)}	_{1.51s (± 1.43%)}	_~	_1.48s	_1.54s	_{p=0.416 n=6}
_{Bind Time}	_{0.77s (± 0.67%)}	_{0.77s (± 0.53%)}	_~	_0.77s	_0.78s	_{p=0.114 n=6}
_{Check Time}	_{9.52s (± 0.37%)}	_{9.47s (± 0.44%)}	_~	_9.40s	_9.53s	_{p=0.107 n=6}
_{Emit Time}	_{2.76s (± 1.01%)}	_{2.74s (± 1.13%)}	_~	_2.70s	_2.77s	_{p=0.376 n=6}
_{Total Time}	_{14.55s (± 0.42%)}	_{14.49s (± 0.43%)}	_~	_14.42s	_14.60s	_{p=0.172 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{346,631k (± 0.01%)}	_{346,607k (± 0.01%)}	_~	_346,585k	_346,638k	_{p=0.199 n=6}
_{Parse Time}	_{2.57s (± 1.01%)}	_{2.59s (± 1.21%)}	_~	_2.55s	_2.63s	_{p=0.375 n=6}
_{Bind Time}	_{1.01s (± 1.02%)}	_{1.01s (± 0.81%)}	_~	_1.00s	_1.02s	_{p=0.928 n=6}
_{Check Time}	_{7.19s (± 0.44%)}	_{7.18s (± 0.51%)}	_~	_7.13s	_7.22s	_{p=0.629 n=6}
_{Emit Time}	_{4.25s (± 0.91%)}	_{4.24s (± 0.93%)}	_~	_4.20s	_4.30s	_{p=0.807 n=6}
_{Total Time}	_{15.01s (± 0.55%)}	_{15.01s (± 0.54%)}	_~	_14.90s	_15.11s	_{p=0.936 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,647k (± 0.00%)}	_{300,661k (± 0.01%)}	_~	_300,628k	_300,703k	_{p=0.422 n=6}
_{Parse Time}	_{2.06s (± 1.50%)}	_{2.06s (± 1.35%)}	_~	_2.03s	_2.10s	_{p=0.936 n=6}
_{Bind Time}	_{1.14s (± 0.86%)}	_{1.14s (± 0.66%)}	_~	_1.13s	_1.15s	_{p=1.000 n=6}
_{Check Time}	_{6.63s (± 0.47%)}	_{6.65s (± 0.57%)}	_~	_6.60s	_6.69s	_{p=0.376 n=6}
_{Emit Time}	_{3.86s (± 0.39%)}	_{3.88s (± 0.53%)}	_~	_3.85s	_3.90s	_{p=0.244 n=6}
_{Total Time}	_{13.70s (± 0.45%)}	_{13.73s (± 0.42%)}	_~	_13.65s	_13.80s	_{p=0.629 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{481,069k (± 0.01%)}	_{482,238k (± 0.01%)}	_{+1,170k (+ 0.24%)}	_482,168k	_482,361k	_{p=0.005 n=6}
_{Parse Time}	_{3.11s (± 0.32%)}	_{3.13s (± 0.48%)}	_~	_3.11s	_3.14s	_{p=0.058 n=6}
_{Bind Time}	_{0.91s (± 0.56%)}	_{0.92s (± 1.49%)}	_~	_0.91s	_0.94s	_{p=0.142 n=6}
_{Check Time}	_{16.88s (± 0.97%)}	_{16.95s (± 0.45%)}	_~	_16.85s	_17.04s	_{p=0.470 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.91s (± 0.80%)}	_{21.00s (± 0.40%)}	_~	_20.90s	_21.10s	_{p=0.334 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{563,155k (± 0.02%)}	_{563,870k (± 0.03%)}	_{+715k (+ 0.13%)}	_563,724k	_564,138k	_{p=0.005 n=6}
_{Parse Time}	_{3.84s (± 0.74%)}	_{3.82s (± 0.85%)}	_~	_3.79s	_3.86s	_{p=0.517 n=6}
_{Bind Time}	_{1.63s (± 0.50%)}	_{1.63s (± 0.72%)}	_~	_1.61s	_1.64s	_{p=0.209 n=6}
_{Check Time}	_{2.79s (± 0.60%)}	_{2.81s (± 0.35%)}	_{+0.02s (+ 0.66%)}	_2.80s	_2.82s	_{p=0.042 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.34s (± 0.40%)}	_{8.35s (± 0.54%)}	_~	_8.30s	_8.42s	_{p=0.935 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,510k (± 0.01%)}	_{365,784k (± 0.01%)}	_{+274k (+ 0.07%)}	_365,735k	_365,866k	_{p=0.005 n=6}
_{Parse Time}	_{3.58s (± 1.08%)}	_{3.57s (± 0.62%)}	_~	_3.55s	_3.60s	_{p=0.870 n=6}
_{Bind Time}	_{1.18s (± 0.54%)}	_{1.18s (± 0.64%)}	_~	_1.17s	_1.19s	_{p=0.718 n=6}
_{Check Time}	_{9.63s (± 0.36%)}	_{9.64s (± 0.25%)}	_~	_9.60s	_9.67s	_{p=0.518 n=6}
_{Emit Time}	_{7.97s (± 0.58%)}	_{7.90s (± 0.30%)}	_{-0.07s (- 0.88%)}	_7.86s	_7.93s	_{p=0.010 n=6}
_{Total Time}	_{22.36s (± 0.44%)}	_{22.30s (± 0.24%)}	_~	_22.21s	_22.37s	_{p=0.148 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,151k (± 0.70%)}	_{193,174k (± 0.69%)}	_~	_192,580k	_195,901k	_{p=0.689 n=6}
_{Parse Time}	_{1.58s (± 1.90%)}	_{1.58s (± 1.52%)}	_~	_1.55s	_1.60s	_{p=0.677 n=6}
_{Bind Time}	_{0.83s (± 0.66%)}	_{0.83s (± 0.99%)}	_~	_0.82s	_0.84s	_{p=0.859 n=6}
_{Check Time}	_{10.22s (± 0.72%)}	_{10.18s (± 0.88%)}	_~	_10.08s	_10.32s	_{p=0.296 n=6}
_{Emit Time}	_{3.02s (± 1.50%)}	_{3.00s (± 0.44%)}	_~	_2.98s	_3.01s	_{p=0.325 n=6}
_{Total Time}	_{15.65s (± 0.57%)}	_{15.59s (± 0.77%)}	_~	_15.43s	_15.77s	_{p=0.297 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,881k (± 0.01%)}	_{345,870k (± 0.00%)}	_~	_345,853k	_345,895k	_{p=0.261 n=6}
_{Parse Time}	_{2.73s (± 0.23%)}	_{2.73s (± 0.72%)}	_~	_2.71s	_2.76s	_{p=1.000 n=6}
_{Bind Time}	_{1.08s (± 0.70%)}	_{1.09s (± 0.69%)}	_~	_1.08s	_1.10s	_{p=0.062 n=6}
_{Check Time}	_{7.87s (± 0.43%)}	_{7.86s (± 0.47%)}	_~	_7.80s	_7.90s	_{p=0.871 n=6}
_{Emit Time}	_{4.47s (± 0.73%)}	_{4.46s (± 0.88%)}	_~	_4.43s	_4.54s	_{p=0.463 n=6}
_{Total Time}	_{16.15s (± 0.22%)}	_{16.15s (± 0.44%)}	_~	_16.06s	_16.27s	_{p=1.000 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,999k (± 0.01%)}	_{299,999k (± 0.01%)}	_~	_299,975k	_300,025k	_{p=0.873 n=6}
_{Parse Time}	_{2.16s (± 0.70%)}	_{2.16s (± 0.92%)}	_~	_2.15s	_2.20s	_{p=0.406 n=6}
_{Bind Time}	_{1.24s (± 0.61%)}	_{1.24s (± 0.97%)}	_~	_1.23s	_1.26s	_{p=0.867 n=6}
_{Check Time}	_{7.30s (± 0.41%)}	_{7.31s (± 0.45%)}	_~	_7.28s	_7.36s	_{p=0.515 n=6}
_{Emit Time}	_{4.32s (± 0.81%)}	_{4.36s (± 0.70%)}	_~	_4.31s	_4.40s	_{p=0.090 n=6}
_{Total Time}	_{15.03s (± 0.39%)}	_{15.07s (± 0.55%)}	_~	_14.98s	_15.22s	_{p=0.574 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{480,317k (± 0.01%)}	_{481,445k (± 0.01%)}	_{+1,128k (+ 0.23%)}	_481,389k	_481,486k	_{p=0.005 n=6}
_{Parse Time}	_{3.25s (± 0.49%)}	_{3.26s (± 0.39%)}	_~	_3.25s	_3.28s	_{p=0.357 n=6}
_{Bind Time}	_{0.94s (± 0.80%)}	_{0.95s (± 1.04%)}	_~	_0.94s	_0.96s	_{p=0.300 n=6}
_{Check Time}	_{17.95s (± 0.53%)}	_{17.91s (± 0.72%)}	_~	_17.77s	_18.08s	_{p=0.226 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.14s (± 0.43%)}	_{22.13s (± 0.66%)}	_~	_21.96s	_22.31s	_{p=0.375 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{560,712k (± 0.03%)}	_{561,377k (± 0.02%)}	_{+666k (+ 0.12%)}	_561,214k	_561,480k	_{p=0.005 n=6}
_{Parse Time}	_{4.00s (± 0.50%)}	_{4.01s (± 0.41%)}	_~	_3.99s	_4.03s	_{p=0.627 n=6}
_{Bind Time}	_{1.76s (± 0.46%)}	_{1.76s (± 0.62%)}	_~	_1.75s	_1.78s	_{p=0.666 n=6}
_{Check Time}	_{3.06s (± 0.34%)}	_{3.06s (± 0.90%)}	_~	_3.03s	_3.10s	_{p=1.000 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.90s (± 0.20%)}	_{8.92s (± 0.48%)}	_~	_8.88s	_8.98s	_{p=0.517 n=6}
_{Angular - node (v14.21.3, x64)}
_{Memory used}	_{359,550k (± 0.01%)}	_{359,783k (± 0.01%)}	_{+233k (+ 0.06%)}	_359,748k	_359,824k	_{p=0.005 n=6}
_{Parse Time}	_{3.67s (± 0.71%)}	_{3.68s (± 0.64%)}	_~	_3.64s	_3.71s	_{p=0.744 n=6}
_{Bind Time}	_{1.22s (± 0.52%)}	_{1.22s (± 0.67%)}	_~	_1.20s	_1.22s	_{p=0.599 n=6}
_{Check Time}	_{10.12s (± 0.36%)}	_{10.10s (± 0.34%)}	_~	_10.04s	_10.14s	_{p=0.335 n=6}
_{Emit Time}	_{8.39s (± 0.99%)}	_{8.36s (± 0.95%)}	_~	_8.26s	_8.47s	_{p=0.630 n=6}
_{Total Time}	_{23.40s (± 0.56%)}	_{23.36s (± 0.41%)}	_~	_23.20s	_23.46s	_{p=0.261 n=6}
_{Compiler-Unions - node (v14.21.3, x64)}
_{Memory used}	_{187,951k (± 0.01%)}	_{187,924k (± 0.01%)}	_~	_187,892k	_187,960k	_{p=0.092 n=6}
_{Parse Time}	_{1.62s (± 0.68%)}	_{1.62s (± 0.82%)}	_~	_1.60s	_1.64s	_{p=0.869 n=6}
_{Bind Time}	_{0.85s (± 0.48%)}	_{0.85s (± 0.96%)}	_~	_0.84s	_0.86s	_{p=0.584 n=6}
_{Check Time}	_{10.35s (± 0.54%)}	_{10.35s (± 0.50%)}	_~	_10.27s	_10.41s	_{p=0.748 n=6}
_{Emit Time}	_{3.15s (± 0.59%)}	_{3.13s (± 0.66%)}	_~	_3.10s	_3.15s	_{p=0.122 n=6}
_{Total Time}	_{15.97s (± 0.37%)}	_{15.94s (± 0.45%)}	_~	_15.84s	_16.00s	_{p=0.257 n=6}
_{Monaco - node (v14.21.3, x64)}
_{Memory used}	_{341,055k (± 0.00%)}	_{341,024k (± 0.01%)}	_~	_340,954k	_341,061k	_{p=0.149 n=6}
_{Parse Time}	_{2.81s (± 0.45%)}	_{2.81s (± 1.22%)}	_~	_2.78s	_2.88s	_{p=0.567 n=6}
_{Bind Time}	_{1.11s (± 0.46%)}	_{1.11s (± 0.37%)}	_~	_1.11s	_1.12s	_{p=0.595 n=6}
_{Check Time}	_{8.21s (± 0.41%)}	_{8.20s (± 0.32%)}	_~	_8.17s	_8.23s	_{p=0.295 n=6}
_{Emit Time}	_{4.70s (± 0.93%)}	_{4.68s (± 0.81%)}	_~	_4.64s	_4.75s	_{p=0.629 n=6}
_{Total Time}	_{16.83s (± 0.41%)}	_{16.80s (± 0.35%)}	_~	_16.73s	_16.88s	_{p=0.520 n=6}
_{TFS - node (v14.21.3, x64)}
_{Memory used}	_{295,154k (± 0.00%)}	_{295,149k (± 0.00%)}	_~	_295,144k	_295,153k	_{p=0.228 n=6}
_{Parse Time}	_{2.40s (± 0.86%)}	_{2.41s (± 0.48%)}	_~	_2.39s	_2.42s	_{p=0.933 n=6}
_{Bind Time}	_{1.07s (± 0.84%)}	_{1.07s (± 1.15%)}	_~	_1.04s	_1.07s	_{p=0.654 n=6}
_{Check Time}	_{7.64s (± 0.65%)}	_{7.66s (± 0.61%)}	_~	_7.61s	_7.73s	_{p=0.936 n=6}
_{Emit Time}	_{4.35s (± 0.89%)}	_{4.36s (± 1.20%)}	_~	_4.27s	_4.43s	_{p=0.467 n=6}
_{Total Time}	_{15.47s (± 0.35%)}	_{15.50s (± 0.62%)}	_~	_15.38s	_15.61s	_{p=0.810 n=6}
_{material-ui - node (v14.21.3, x64)}
_{Memory used}	_{475,892k (± 0.01%)}	_{477,002k (± 0.01%)}	_{+1,110k (+ 0.23%)}	_476,940k	_477,025k	_{p=0.005 n=6}
_{Parse Time}	_{3.34s (± 0.86%)}	_{3.36s (± 0.36%)}	_~	_3.34s	_3.37s	_{p=0.220 n=6}
_{Bind Time}	_{1.00s (± 0.63%)}	_{1.00s (± 0.41%)}	_~	_1.00s	_1.01s	_{p=0.673 n=6}
_{Check Time}	_{18.88s (± 0.65%)}	_{18.88s (± 0.52%)}	_~	_18.78s	_19.07s	_{p=0.872 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.22s (± 0.51%)}	_{23.24s (± 0.46%)}	_~	_23.11s	_23.43s	_{p=0.574 n=6}
_{xstate - node (v14.21.3, x64)}
_{Memory used}	_{549,649k (± 0.00%)}	_{550,373k (± 0.00%)}	_{+724k (+ 0.13%)}	_550,356k	_550,390k	_{p=0.005 n=6}
_{Parse Time}	_{4.25s (± 0.58%)}	_{4.23s (± 0.49%)}	_~	_4.21s	_4.27s	_{p=0.191 n=6}
_{Bind Time}	_{1.67s (± 0.50%)}	_{1.68s (± 0.31%)}	_~	_1.68s	_1.69s	_{p=0.073 n=6}
_{Check Time}	_{3.16s (± 0.74%)}	_{3.16s (± 0.60%)}	_~	_3.13s	_3.18s	_{p=0.808 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.17s (± 0.40%)}	_{9.17s (± 0.32%)}	_~	_9.14s	_9.21s	_{p=0.686 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.21.3, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.21.3, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.21.3, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.21.3, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.21.3, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₇₂₅	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..54725

_Metric	_main	₅₄₇₂₅	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,544ms (± 0.41%)}	_{2,540ms (± 0.36%)}	_~	_2,524ms	_2,548ms	_{p=0.747 n=6}
_{Req 2 - geterr}	_{5,568ms (± 0.62%)}	_{5,564ms (± 0.74%)}	_~	_5,504ms	_5,615ms	_{p=1.000 n=6}
_{Req 3 - references}	_{336ms (± 0.59%)}	_{336ms (± 0.58%)}	_~	_333ms	_338ms	_{p=0.461 n=6}
_{Req 4 - navto}	_{289ms (± 2.02%)}	_{287ms (± 0.28%)}	_~	_286ms	_288ms	_{p=0.870 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 1.16%)}	_{85ms (± 0.99%)}	_~	_83ms	_85ms	_{p=0.445 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,637ms (± 0.79%)}	_{2,656ms (± 0.53%)}	_~	_2,635ms	_2,675ms	_{p=0.128 n=6}
_{Req 2 - geterr}	_{4,278ms (± 1.76%)}	_{4,296ms (± 0.48%)}	_~	_4,268ms	_4,330ms	_{p=0.689 n=6}
_{Req 3 - references}	_{356ms (± 5.45%)}	_{351ms (± 0.47%)}	_~	_349ms	_353ms	_{p=0.090 n=6}
_{Req 4 - navto}	_{287ms (± 0.52%)}	_{288ms (± 0.41%)}	_~	_286ms	_289ms	_{p=0.187 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{64ms (± 4.29%)}	_{67ms (± 5.27%)}	_~	_62ms	_69ms	_{p=0.310 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,079ms (± 0.64%)}	_{3,095ms (± 0.44%)}	_~	_3,079ms	_3,116ms	_{p=0.230 n=6}
_{Req 2 - geterr}	_{1,560ms (± 1.02%)}	_{1,570ms (± 1.34%)}	_~	_1,539ms	_1,597ms	_{p=0.378 n=6}
_{Req 3 - references}	_{113ms (± 0.93%)}	_{113ms (± 1.54%)}	_~	_112ms	_116ms	_{p=0.558 n=6}
_{Req 4 - navto}	_{359ms (± 0.34%)}	_{368ms (± 0.40%)}	_{+9ms (+ 2.56%)}	_366ms	_370ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_{2,864 (± 0.00%)}	_{2,870 (± 0.00%)}	_{+6 (+ 0.21%)}	_2,870	_2,870	_{p=0.001 n=6}
_{Req 5 - completionInfo}	_{376ms (± 2.04%)}	_{374ms (± 2.41%)}	_~	_363ms	_386ms	_{p=0.936 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,665ms (± 0.56%)}	_{2,658ms (± 0.77%)}	_~	_2,633ms	_2,682ms	_{p=0.689 n=6}
_{Req 2 - geterr}	_{6,019ms (± 0.44%)}	_{6,023ms (± 0.52%)}	_~	_5,989ms	_6,072ms	_{p=1.000 n=6}
_{Req 3 - references}	_{353ms (± 0.53%)}	_{351ms (± 0.43%)}	_~	_350ms	_354ms	_{p=0.289 n=6}
_{Req 4 - navto}	_{287ms (± 1.30%)}	_{287ms (± 1.42%)}	_~	_282ms	_294ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{89ms (± 5.55%)}	_{93ms (± 1.58%)}	_~	_91ms	_95ms	_{p=0.120 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,841ms (± 0.80%)}	_{2,849ms (± 0.60%)}	_~	_2,832ms	_2,873ms	_{p=0.298 n=6}
_{Req 2 - geterr}	_{4,678ms (± 0.57%)}	_{4,679ms (± 0.56%)}	_~	_4,631ms	_4,703ms	_{p=1.000 n=6}
_{Req 3 - references}	_{364ms (± 0.33%)}	_{366ms (± 0.41%)}	_~	_364ms	_368ms	_{p=0.219 n=6}
_{Req 4 - navto}	_{282ms (± 0.62%)}	_{284ms (± 0.91%)}	_~	_279ms	_287ms	_{p=0.183 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{68ms (± 1.11%)}	_{68ms (± 0.60%)}	_~	_68ms	_69ms	_{p=0.389 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,213ms (± 0.41%)}	_{3,238ms (± 0.37%)}	_{+24ms (+ 0.76%)}	_3,225ms	_3,256ms	_{p=0.020 n=6}
_{Req 2 - geterr}	_{1,718ms (± 0.53%)}	_{1,721ms (± 0.60%)}	_~	_1,711ms	_1,737ms	_{p=0.688 n=6}
_{Req 3 - references}	_{122ms (± 1.31%)}	_{123ms (± 1.08%)}	_~	_121ms	_124ms	_{p=0.154 n=6}
_{Req 4 - navto}	_{341ms (± 0.76%)}	_{352ms (± 0.83%)}	_{+12ms (+ 3.38%)}	_349ms	_356ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_{2,864 (± 0.00%)}	_{2,870 (± 0.00%)}	_{+6 (+ 0.21%)}	_2,870	_2,870	_{p=0.001 n=6}
_{Req 5 - completionInfo}	_{412ms (± 1.03%)}	_{404ms (± 1.10%)}	_{-8ms (- 1.90%)}	_395ms	_407ms	_{p=0.005 n=6}
_{Compiler-UnionsTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,788ms (± 0.37%)}	_{2,812ms (± 0.40%)}	_{+24ms (+ 0.86%)}	_2,799ms	_2,828ms	_{p=0.008 n=6}
_{Req 2 - geterr}	_{6,202ms (± 0.94%)}	_{6,196ms (± 0.78%)}	_~	_6,135ms	_6,245ms	_{p=1.000 n=6}
_{Req 3 - references}	_{372ms (± 5.04%)}	_{364ms (± 0.61%)}	_~	_361ms	_367ms	_{p=0.419 n=6}
_{Req 4 - navto}	_{290ms (± 0.95%)}	_{289ms (± 0.28%)}	_~	_288ms	_290ms	_{p=0.740 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{97ms (± 6.11%)}	_{101ms (± 1.63%)}	_~	_98ms	_103ms	_{p=0.746 n=6}
_{CompilerTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,989ms (± 0.34%)}	_{2,982ms (± 0.53%)}	_~	_2,966ms	_3,009ms	_{p=0.297 n=6}
_{Req 2 - geterr}	_{4,554ms (± 0.89%)}	_{4,542ms (± 0.56%)}	_~	_4,501ms	_4,575ms	_{p=0.378 n=6}
_{Req 3 - references}	_{373ms (± 1.03%)}	_{373ms (± 0.71%)}	_~	_370ms	_377ms	_{p=0.935 n=6}
_{Req 4 - navto}	_{298ms (± 0.72%)}	_{298ms (± 0.25%)}	_~	_297ms	_299ms	_{p=0.463 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{77ms (± 2.51%)}	_{77ms (± 3.33%)}	_~	_75ms	_82ms	_{p=0.325 n=6}
_{xstateTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{3,468ms (± 0.91%)}	_{3,456ms (± 1.29%)}	_~	_3,391ms	_3,497ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{1,835ms (± 0.34%)}	_{1,826ms (± 0.69%)}	_~	_1,811ms	_1,839ms	_{p=0.470 n=6}
_{Req 3 - references}	_{158ms (± 5.55%)}	_{151ms (± 8.56%)}	_~	_131ms	_163ms	_{p=0.196 n=6}
_{Req 4 - navto}	_{407ms (± 2.10%)}	_{396ms (± 2.39%)}	_~	_385ms	_413ms	_{p=0.054 n=6}
_{Req 5 - completionInfo count}	_{2,864 (± 0.00%)}	_{2,870 (± 0.00%)}	_{+6 (+ 0.21%)}	_2,870	_2,870	_{p=0.001 n=6}
_{Req 5 - completionInfo}	_{434ms (± 3.08%)}	_{428ms (± 3.03%)}	_~	_406ms	_439ms	_{p=0.173 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.21.3, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.21.3, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₇₂₅	₆
_Baseline	_main	₆

Startup

Comparison Report - main..54725

_Metric	_main	₅₄₇₂₅	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{141.48ms (± 0.22%)}	_{141.91ms (± 0.22%)}	_{+0.43ms (+ 0.31%)}	_141.06ms	_147.70ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{220.54ms (± 0.19%)}	_{221.34ms (± 0.16%)}	_{+0.80ms (+ 0.36%)}	_220.29ms	_225.15ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{221.94ms (± 0.21%)}	_{222.59ms (± 0.16%)}	_{+0.65ms (+ 0.29%)}	_221.44ms	_225.53ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{203.90ms (± 0.27%)}	_{204.27ms (± 0.17%)}	_{+0.36ms (+ 0.18%)}	_203.32ms	_210.30ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₇₂₅	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-06-21T17:46:36Z

@sandersn Here are the results of running the top-repos suite comparing main and refs/pull/54725/merge:

Everything looks good!

typescript-bot · 2023-06-21T18:02:04Z

Hey @sandersn, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

typescript-bot · 2023-06-21T18:30:00Z

@sandersn Here are the results of running the top-repos suite comparing main and refs/pull/54725/merge:

Everything looks good!

sandersn · 2023-06-21T19:27:43Z

Perf looks OK, just a little more memory used than before.

jpzwarte · 2023-07-01T18:39:46Z

@sandersn this doesn't include the beforetoggle event from popover? https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/beforetoggle_event

jakub-tucek · 2023-08-28T08:01:41Z

src/lib/dom.generated.d.ts

    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/ScreenOrientation/type) */
    readonly type: OrientationType;
-    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/ScreenOrientation/lock) */
-    lock(orientation: OrientationLockType): Promise<void>;


Is this change correct? It seems like this shouldn't be removed

microsoft/TypeScript-DOM-lib-generator#1615

DOM update 2023/06/21

6cdba31

typescript-bot assigned sandersn Jun 21, 2023

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jun 21, 2023

sandersn requested review from DanielRosenwasser and weswigham June 21, 2023 16:32

sandersn merged commit e69a0b0 into microsoft:main Jun 21, 2023

sandersn deleted the dom-update-2023-06-21 branch June 29, 2023 23:41

kt3k mentioned this pull request Jul 13, 2023

chore: simplify getSetCookies denoland/std#3491

Merged

mattcosta7 mentioned this pull request Aug 25, 2023

feat: support TypeScript 5.2 mswjs/msw#1711

Merged

jakub-tucek reviewed Aug 28, 2023

View reviewed changes

yanndinendal mentioned this pull request Oct 9, 2023

Draft: [react] Add jsx autoComplete types from the DOM DefinitelyTyped/DefinitelyTyped#66982

Closed

8 tasks

dtarnawsky mentioned this pull request Nov 21, 2023

fix(screen-orientation): Add OrientationLockType ionic-team/capacitor-plugins#1914

Merged

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Conversation

sandersn commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sandersn commented Jun 21, 2023

Uh oh!

typescript-bot commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 21, 2023

Uh oh!

typescript-bot commented Jun 21, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

Uh oh!

typescript-bot commented Jun 21, 2023

Compiler

TSServer

Startup

Uh oh!

typescript-bot commented Jun 21, 2023

Uh oh!

typescript-bot commented Jun 21, 2023

Uh oh!

typescript-bot commented Jun 21, 2023

Uh oh!

sandersn commented Jun 21, 2023

Uh oh!

jpzwarte commented Jul 1, 2023

Uh oh!

jakub-tucek Aug 28, 2023

Choose a reason for hiding this comment

Uh oh!

mistic100 Aug 28, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sandersn commented Jun 21, 2023 •

edited

Loading

typescript-bot commented Jun 21, 2023 •

edited

Loading

typescript-bot commented Jun 21, 2023 •

edited

Loading

typescript-bot commented Jun 21, 2023 •

edited

Loading

typescript-bot commented Jun 21, 2023 •

edited

Loading

typescript-bot commented Jun 21, 2023 •

edited

Loading

typescript-bot commented Jun 21, 2023 •

edited

Loading

typescript-bot commented Jun 21, 2023 •

edited

Loading