Treat this as a constant reference for purpose of narrowing using aliased expressions#54347
Merged
sandersn merged 1 commit intomicrosoft:mainfrom Jun 1, 2023
Merged
Conversation
…liased expressions
sandersn
requested changes
Jun 1, 2023
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Question about a diff in an existing test.
| // Some narrowings may be invalidated due to later assignments. | ||
| let s: string; | ||
| s = this.x; | ||
| ~ |
Member
There was a problem hiding this comment.
I would expect this to match s = x on the next line, as it does in the previous diff. Why does the error go away for s = this.x here, but not for s = x?
For that matter, why does assignment in the else branch prevent narrowing in the if branch?
Member
There was a problem hiding this comment.
There's an assignment to x in the else branch that causes x to viewed as mutable and therefore it isn't narrowed. There's a comment to that effect in the test, so not unexpected.
Member
|
@typescript-bot test this |
Collaborator
|
Heya @sandersn, I've started to run the perf test suite on this PR at c6ebde7. You can monitor the build here. Update: The results are in! |
Collaborator
Collaborator
Collaborator
|
Heya @sandersn, I've started to run the diff-based top-repos suite on this PR at c6ebde7. You can monitor the build here. Update: The results are in! |
Collaborator
Collaborator
|
Heya @sandersn, I've started to run the diff-based top-repos suite (tsserver) on this PR at c6ebde7. You can monitor the build here. Update: The results are in! |
Collaborator
Collaborator
|
Heya @sandersn, I've started to run the diff-based user code test suite (tsserver) on this PR at c6ebde7. You can monitor the build here. Update: The results are in! |
Collaborator
|
Hey @sandersn, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
ahejlsberg
approved these changes
Jun 1, 2023
| // Some narrowings may be invalidated due to later assignments. | ||
| let s: string; | ||
| s = this.x; | ||
| ~ |
Member
There was a problem hiding this comment.
There's an assignment to x in the else branch that causes x to viewed as mutable and therefore it isn't narrowed. There's a comment to that effect in the test, so not unexpected.
sandersn
approved these changes
Jun 1, 2023
Collaborator
|
@sandersn Here are the results of running the user test suite comparing Everything looks good! |
Collaborator
|
@sandersn Here are the results of running the top-repos suite comparing Everything looks good! |
Collaborator
|
@sandersn Here they are:
CompilerComparison Report - main..54347
System
Hosts
Scenarios
TSServerComparison Report - main..54347
System
Hosts
Scenarios
StartupComparison Report - main..54347
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Collaborator
|
@sandersn Here are the results of running the top-repos suite comparing Everything looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #53267