Treat `TemplateExpression` as possibly discriminant values by Andarist · Pull Request #53903 · microsoft/TypeScript

Andarist · 2023-04-18T22:44:49Z

fixes the case based on which #53888 was created but it doesn't fix the case with which it was created 😅

typescript-bot · 2023-04-18T22:44:54Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

jakebailey · 2023-04-18T22:48:18Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster
@typescript-bot pack this

typescript-bot · 2023-04-18T22:48:21Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 0c66314. You can monitor the build here.

typescript-bot · 2023-04-18T22:48:21Z

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 0c66314. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-18T22:48:21Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 0c66314. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-18T22:48:21Z

Heya @jakebailey, I've started to run the extended test suite on this PR at 0c66314. You can monitor the build here.

typescript-bot · 2023-04-18T22:48:21Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 0c66314. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-18T22:48:22Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 0c66314. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-18T22:50:04Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/152844/artifacts?artifactName=tgz&fileId=A1D97AECE465788DD56A58BE9EA362D7EC321DED81E66C7BCE8F81C6169D319D02&fileName=/typescript-5.1.0-insiders.20230418.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-53903-8".;

typescript-bot · 2023-04-18T23:00:30Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53903/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-04-18T23:17:37Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53903

_Metric	_main	₅₃₉₀₃	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,132k (± 0.01%)}	_{365,158k (± 0.01%)}	_~	_365,108k	_365,197k	_{p=0.093 n=6}
_{Parse Time}	_{3.53s (± 0.55%)}	_{3.54s (± 0.42%)}	_~	_3.52s	_3.56s	_{p=0.255 n=6}
_{Bind Time}	_{1.18s (± 0.44%)}	_{1.18s (± 0.83%)}	_~	_1.17s	_1.19s	_{p=0.931 n=6}
_{Check Time}	_{9.51s (± 0.53%)}	_{9.52s (± 0.46%)}	_~	_9.46s	_9.56s	_{p=0.809 n=6}
_{Emit Time}	_{7.89s (± 0.59%)}	_{7.96s (± 0.79%)}	_~	_7.90s	_8.06s	_{p=0.090 n=6}
_{Total Time}	_{22.10s (± 0.28%)}	_{22.20s (± 0.45%)}	_~	_22.09s	_22.34s	_{p=0.199 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,202k (± 0.75%)}	_{192,648k (± 0.04%)}	_~	_192,512k	_192,719k	_{p=0.689 n=6}
_{Parse Time}	_{1.58s (± 1.24%)}	_{1.59s (± 0.51%)}	_~	_1.58s	_1.60s	_{p=0.411 n=6}
_{Bind Time}	_{0.82s (± 0.50%)}	_{0.83s (± 0.76%)}	_{+0.01s (+ 1.43%)}	_0.82s	_0.84s	_{p=0.009 n=6}
_{Check Time}	_{10.17s (± 0.50%)}	_{10.24s (± 0.33%)}	_{+0.07s (+ 0.72%)}	_10.21s	_10.28s	_{p=0.019 n=6}
_{Emit Time}	_{2.97s (± 0.58%)}	_{2.98s (± 0.45%)}	_~	_2.96s	_3.00s	_{p=0.622 n=6}
_{Total Time}	_{15.54s (± 0.27%)}	_{15.64s (± 0.29%)}	_{+0.10s (+ 0.63%)}	_15.59s	_15.69s	_{p=0.020 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,768k (± 0.00%)}	_{345,761k (± 0.01%)}	_~	_345,728k	_345,853k	_{p=0.128 n=6}
_{Parse Time}	_{2.72s (± 0.38%)}	_{2.72s (± 0.38%)}	_~	_2.71s	_2.74s	_{p=0.391 n=6}
_{Bind Time}	_{1.09s (± 0.82%)}	_{1.08s (± 0.96%)}	_~	_1.06s	_1.09s	_{p=0.054 n=6}
_{Check Time}	_{7.81s (± 0.45%)}	_{7.82s (± 0.86%)}	_~	_7.76s	_7.93s	_{p=0.872 n=6}
_{Emit Time}	_{4.44s (± 0.66%)}	_{4.44s (± 0.73%)}	_~	_4.41s	_4.50s	_{p=1.000 n=6}
_{Total Time}	_{16.05s (± 0.38%)}	_{16.07s (± 0.54%)}	_~	_15.99s	_16.19s	_{p=0.872 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,054k (± 0.01%)}	_{300,044k (± 0.01%)}	_~	_300,015k	_300,063k	_{p=0.230 n=6}
_{Parse Time}	_{2.16s (± 0.74%)}	_{2.16s (± 0.56%)}	_~	_2.14s	_2.17s	_{p=1.000 n=6}
_{Bind Time}	_{1.25s (± 1.31%)}	_{1.25s (± 0.94%)}	_~	_1.24s	_1.27s	_{p=0.932 n=6}
_{Check Time}	_{7.21s (± 0.68%)}	_{7.21s (± 0.45%)}	_~	_7.16s	_7.25s	_{p=0.809 n=6}
_{Emit Time}	_{4.36s (± 1.46%)}	_{4.35s (± 0.93%)}	_~	_4.31s	_4.43s	_{p=0.936 n=6}
_{Total Time}	_{14.97s (± 0.77%)}	_{14.97s (± 0.45%)}	_~	_14.90s	_15.07s	_{p=1.000 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,550k (± 0.01%)}	_{481,599k (± 0.01%)}	_~	_481,524k	_481,660k	_{p=0.173 n=6}
_{Parse Time}	_{3.26s (± 0.61%)}	_{3.25s (± 0.57%)}	_~	_3.23s	_3.27s	_{p=0.452 n=6}
_{Bind Time}	_{0.95s (± 0.67%)}	_{0.94s (± 0.86%)}	_~	_0.93s	_0.95s	_{p=0.177 n=6}
_{Check Time}	_{17.97s (± 0.68%)}	_{17.87s (± 0.69%)}	_~	_17.75s	_18.03s	_{p=0.127 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.17s (± 0.63%)}	_{22.06s (± 0.61%)}	_~	_21.93s	_22.24s	_{p=0.199 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{561,294k (± 0.02%)}	_{561,344k (± 0.03%)}	_~	_561,180k	_561,605k	_{p=0.810 n=6}
_{Parse Time}	_{4.04s (± 0.41%)}	_{4.05s (± 0.47%)}	_~	_4.02s	_4.07s	_{p=0.324 n=6}
_{Bind Time}	_{1.77s (± 0.43%)}	_{1.77s (± 0.50%)}	_~	_1.76s	_1.78s	_{p=0.798 n=6}
_{Check Time}	_{3.03s (± 0.54%)}	_{3.03s (± 0.34%)}	_~	_3.02s	_3.05s	_{p=1.000 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.94s (± 0.35%)}	_{8.94s (± 0.16%)}	_~	_8.92s	_8.96s	_{p=1.000 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₉₀₃	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

jakebailey · 2023-04-18T23:22:18Z

I don't believe you

@typescript-bot perf test this faster

typescript-bot · 2023-04-18T23:22:23Z

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 0c66314. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-18T23:37:45Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53903

_Metric	_main	₅₃₉₀₃	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,132k (± 0.01%)}	_{365,157k (± 0.01%)}	_~	_365,102k	_365,217k	_{p=0.471 n=6}
_{Parse Time}	_{3.53s (± 0.55%)}	_{3.53s (± 0.58%)}	_~	_3.51s	_3.57s	_{p=1.000 n=6}
_{Bind Time}	_{1.18s (± 0.44%)}	_{1.17s (± 0.47%)}	_~	_1.17s	_1.18s	_{p=0.640 n=6}
_{Check Time}	_{9.51s (± 0.53%)}	_{9.51s (± 0.51%)}	_~	_9.44s	_9.59s	_{p=1.000 n=6}
_{Emit Time}	_{7.89s (± 0.59%)}	_{7.92s (± 0.39%)}	_~	_7.89s	_7.97s	_{p=0.227 n=6}
_{Total Time}	_{22.10s (± 0.28%)}	_{22.14s (± 0.25%)}	_~	_22.08s	_22.24s	_{p=0.936 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,202k (± 0.75%)}	_{192,626k (± 0.03%)}	_~	_192,525k	_192,676k	_{p=0.936 n=6}
_{Parse Time}	_{1.58s (± 1.24%)}	_{1.60s (± 0.26%)}	_~	_1.59s	_1.60s	_{p=0.198 n=6}
_{Bind Time}	_{0.82s (± 0.50%)}	_{0.83s (± 0.62%)}	_{+0.02s (+ 1.83%)}	_0.83s	_0.84s	_{p=0.003 n=6}
_{Check Time}	_{10.17s (± 0.50%)}	_{10.29s (± 0.65%)}	_{+0.13s (+ 1.23%)}	_10.20s	_10.37s	_{p=0.016 n=6}
_{Emit Time}	_{2.97s (± 0.58%)}	_{3.01s (± 1.21%)}	_~	_2.97s	_3.07s	_{p=0.053 n=6}
_{Total Time}	_{15.54s (± 0.27%)}	_{15.73s (± 0.56%)}	_{+0.19s (+ 1.23%)}	_15.61s	_15.85s	_{p=0.008 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,768k (± 0.00%)}	_{345,808k (± 0.01%)}	_~	_345,734k	_345,872k	_{p=0.173 n=6}
_{Parse Time}	_{2.72s (± 0.38%)}	_{2.73s (± 0.72%)}	_~	_2.71s	_2.76s	_{p=0.183 n=6}
_{Bind Time}	_{1.09s (± 0.82%)}	_{1.07s (± 1.52%)}	_~	_1.05s	_1.09s	_{p=0.084 n=6}
_{Check Time}	_{7.81s (± 0.45%)}	_{7.84s (± 0.52%)}	_~	_7.77s	_7.88s	_{p=0.228 n=6}
_{Emit Time}	_{4.44s (± 0.66%)}	_{4.47s (± 0.70%)}	_~	_4.42s	_4.49s	_{p=0.126 n=6}
_{Total Time}	_{16.05s (± 0.38%)}	_{16.11s (± 0.32%)}	_~	_16.05s	_16.16s	_{p=0.077 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,054k (± 0.01%)}	_{300,044k (± 0.01%)}	_~	_300,021k	_300,070k	_{p=0.298 n=6}
_{Parse Time}	_{2.16s (± 0.74%)}	_{2.15s (± 0.68%)}	_~	_2.13s	_2.17s	_{p=0.317 n=6}
_{Bind Time}	_{1.25s (± 1.31%)}	_{1.24s (± 0.83%)}	_~	_1.22s	_1.25s	_{p=0.183 n=6}
_{Check Time}	_{7.21s (± 0.68%)}	_{7.18s (± 0.31%)}	_~	_7.14s	_7.20s	_{p=0.258 n=6}
_{Emit Time}	_{4.36s (± 1.46%)}	_{4.36s (± 0.65%)}	_~	_4.32s	_4.40s	_{p=1.000 n=6}
_{Total Time}	_{14.97s (± 0.77%)}	_{14.92s (± 0.33%)}	_~	_14.85s	_14.97s	_{p=0.297 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,550k (± 0.01%)}	_{481,488k (± 0.00%)}	_{-63k (- 0.01%)}	_481,468k	_481,520k	_{p=0.030 n=6}
_{Parse Time}	_{3.26s (± 0.61%)}	_{3.25s (± 0.75%)}	_~	_3.23s	_3.29s	_{p=0.504 n=6}
_{Bind Time}	_{0.95s (± 0.67%)}	_{0.94s (± 0.58%)}	_~	_0.94s	_0.95s	_{p=0.201 n=6}
_{Check Time}	_{17.97s (± 0.68%)}	_{17.76s (± 0.46%)}	_{-0.21s (- 1.15%)}	_17.65s	_17.86s	_{p=0.016 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.17s (± 0.63%)}	_{21.96s (± 0.42%)}	_{-0.21s (- 0.97%)}	_21.84s	_22.10s	_{p=0.020 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{561,294k (± 0.02%)}	_{561,318k (± 0.02%)}	_~	_561,168k	_561,460k	_{p=0.689 n=6}
_{Parse Time}	_{4.04s (± 0.41%)}	_{4.05s (± 0.30%)}	_~	_4.04s	_4.07s	_{p=0.211 n=6}
_{Bind Time}	_{1.77s (± 0.43%)}	_{1.77s (± 0.47%)}	_~	_1.76s	_1.78s	_{p=0.172 n=6}
_{Check Time}	_{3.03s (± 0.54%)}	_{3.04s (± 0.38%)}	_~	_3.02s	_3.05s	_{p=0.622 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.94s (± 0.35%)}	_{8.96s (± 0.15%)}	_~	_8.94s	_8.98s	_{p=0.125 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₉₀₃	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-04-19T00:47:28Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53903/merge:

Everything looks good!

typescript-bot · 2023-04-19T00:57:53Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

Andarist · 2023-05-15T22:23:59Z

This got merged as part of #53907

Treat TemplateExpression as possibly discriminant values

0c66314

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 18, 2023

Andarist mentioned this pull request Apr 19, 2023

Evaluate simple template expressions #53907

Merged

sandersn assigned gabritto May 2, 2023

sandersn requested review from gabritto and weswigham May 2, 2023 23:00

Andarist closed this May 15, 2023

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Comments

Conversation

Andarist commented Apr 18, 2023

Uh oh!

typescript-bot commented Apr 18, 2023

Uh oh!

jakebailey commented Apr 18, 2023

Uh oh!

typescript-bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 18, 2023

Uh oh!

typescript-bot commented Apr 18, 2023

Uh oh!

jakebailey commented Apr 18, 2023

Uh oh!

typescript-bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 18, 2023

Uh oh!

typescript-bot commented Apr 19, 2023

Uh oh!

typescript-bot commented Apr 19, 2023

Uh oh!

Andarist commented May 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

typescript-bot commented Apr 18, 2023 •

edited

Loading

typescript-bot commented Apr 18, 2023 •

edited

Loading

typescript-bot commented Apr 18, 2023 •

edited

Loading

typescript-bot commented Apr 18, 2023 •

edited

Loading

typescript-bot commented Apr 18, 2023 •

edited

Loading

typescript-bot commented Apr 18, 2023 •

edited

Loading

typescript-bot commented Apr 18, 2023 •

edited

Loading

typescript-bot commented Apr 18, 2023 •

edited

Loading