Properly handle partial union type properties in isTypePresencePossible

[ahejlsberg]

Fixes #53773.

[ahejlsberg]

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

[typescript-bot]

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 119eb2a. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 119eb2a. You can monitor the build here.

[typescript-bot]

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 119eb2a. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at 119eb2a. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 119eb2a. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/53794/merge:

There were infrastructure failures potentially unrelated to your change:

• 1 instance of "Package install failed"

Otherwise...

Everything looks good!

[typescript-bot]

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53794

Metric	main	53794	Delta	Best	Worst	p-value
Angular - node (v16.17.1, x64)
Memory used	364,557k (± 0.01%)	364,553k (± 0.01%)	~	364,516k	364,572k	p=0.423 n=6
Parse Time	3.55s (± 0.37%)	3.54s (± 0.42%)	~	3.53s	3.56s	p=0.458 n=6
Bind Time	1.18s (± 0.46%)	1.18s (± 0.71%)	~	1.17s	1.19s	p=0.855 n=6
Check Time	9.51s (± 0.42%)	9.51s (± 0.39%)	~	9.46s	9.57s	p=0.808 n=6
Emit Time	7.96s (± 1.35%)	7.94s (± 0.40%)	~	7.90s	7.98s	p=0.809 n=6
Total Time	22.21s (± 0.53%)	22.17s (± 0.23%)	~	22.11s	22.25s	p=0.936 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	192,574k (± 0.03%)	192,555k (± 0.04%)	~	192,465k	192,691k	p=0.575 n=6
Parse Time	1.59s (± 0.32%)	1.57s (± 1.74%)	~	1.54s	1.61s	p=0.199 n=6
Bind Time	0.83s (± 0.66%)	0.82s (± 0.92%)	~	0.81s	0.83s	p=0.476 n=6
Check Time	10.19s (± 0.44%)	10.21s (± 0.56%)	~	10.15s	10.30s	p=0.629 n=6
Emit Time	2.97s (± 0.66%)	3.02s (± 1.52%)	~	2.96s	3.09s	p=0.052 n=6
Total Time	15.59s (± 0.31%)	15.63s (± 0.32%)	~	15.56s	15.68s	p=0.260 n=6
Monaco - node (v16.17.1, x64)
Memory used	345,754k (± 0.01%)	345,749k (± 0.01%)	~	345,717k	345,795k	p=0.873 n=6
Parse Time	2.71s (± 0.30%)	2.72s (± 0.30%)	~	2.71s	2.73s	p=0.666 n=6
Bind Time	1.08s (± 0.75%)	1.09s (± 0.90%)	~	1.08s	1.11s	p=0.177 n=6
Check Time	7.83s (± 0.48%)	7.84s (± 0.42%)	~	7.79s	7.89s	p=0.872 n=6
Emit Time	4.45s (± 0.93%)	4.47s (± 1.55%)	~	4.39s	4.55s	p=0.871 n=6
Total Time	16.07s (± 0.49%)	16.11s (± 0.54%)	~	16.00s	16.22s	p=0.521 n=6
TFS - node (v16.17.1, x64)
Memory used	300,031k (± 0.00%)	300,066k (± 0.01%)	+36k (+ 0.01%)	300,018k	300,098k	p=0.045 n=6
Parse Time	2.15s (± 0.78%)	2.15s (± 0.72%)	~	2.14s	2.18s	p=0.933 n=6
Bind Time	1.23s (± 0.33%)	1.24s (± 0.79%)	~	1.23s	1.25s	p=0.056 n=6
Check Time	7.18s (± 0.26%)	7.17s (± 0.32%)	~	7.13s	7.19s	p=0.505 n=6
Emit Time	4.35s (± 0.84%)	4.33s (± 0.98%)	~	4.26s	4.37s	p=0.518 n=6
Total Time	14.90s (± 0.42%)	14.88s (± 0.40%)	~	14.78s	14.94s	p=0.572 n=6
material-ui - node (v16.17.1, x64)
Memory used	481,160k (± 0.01%)	481,134k (± 0.01%)	~	481,075k	481,172k	p=0.471 n=6
Parse Time	3.24s (± 0.42%)	3.25s (± 0.34%)	~	3.23s	3.26s	p=0.491 n=6
Bind Time	0.94s (± 0.88%)	0.95s (± 0.43%)	~	0.94s	0.95s	p=0.285 n=6
Check Time	17.82s (± 0.65%)	17.80s (± 0.46%)	~	17.68s	17.93s	p=0.872 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	22.00s (± 0.55%)	22.00s (± 0.36%)	~	21.88s	22.11s	p=0.936 n=6
xstate - node (v16.17.1, x64)
Memory used	559,385k (± 0.03%)	559,338k (± 0.01%)	~	559,281k	559,427k	p=0.936 n=6
Parse Time	3.98s (± 0.27%)	3.99s (± 0.52%)	~	3.97s	4.02s	p=0.157 n=6
Bind Time	1.75s (± 0.30%)	1.75s (± 0.43%)	~	1.74s	1.76s	p=0.784 n=6
Check Time	3.02s (± 0.44%)	3.01s (± 0.28%)	~	3.00s	3.02s	p=0.075 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=1.000 n=6
Total Time	8.83s (± 0.19%)	8.85s (± 0.17%)	~	8.82s	8.86s	p=0.138 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• Angular - node (v16.17.1, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Monaco - node (v16.17.1, x64)
• TFS - node (v16.17.1, x64)
• material-ui - node (v16.17.1, x64)
• xstate - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	53794	6
Baseline	main	6

Developer Information:

Download Benchmark

[typescript-bot]

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

[typescript-bot]

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/53794/merge:

Everything looks good!

[ahejlsberg]

Tests all clean and performance is unaffected. This is ready to merge.