Revert part of catch clause PR which broke other declarations

[jakebailey]

Fixes #52401

In #52240, I tacked on an extra commit which was intended to optimize/fix getControlFlowContainer and assumeInitialized (pulled from my "arbitrary catch clause annotations" PR as it was required to make tsserver happy).

It turned out to have an unintended negative effect. I actually think that this change was correct, and that assumeInitialized is actually missing more nodes that should be containers (as defined by the binder), but for purposes of the beta I want to just revert this and investigate later.

[jakebailey]

I actually think that this change was correct, and that assumeInitialized is actually missing more nodes that should be containers (as defined by the binder), but for purposes of the beta I want to just revert this and investigate later.

On second look, we actually have specific types for these and they are distinct, IsBlockScopedContainer and IsControlFlowContainer. So, maybe I'm just straight up wrong. In any case, this part of my previous PR should be reverted.

[DanielRosenwasser]

@typescript-bot pack this
@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot perf test this faster

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 3cc8892. You can monitor the build here.

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 3cc8892. You can monitor the build here.

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at 3cc8892. You can monitor the build here.

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at 3cc8892. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at 3cc8892. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at 3cc8892. You can monitor the build here.

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 3cc8892. You can monitor the build here.

[typescript-bot]

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/143951/artifacts?artifactName=tgz&fileId=EEEAD07BC7A612D48353E8962C8C865C3A5E3F12B4A87A197BE793C408A8EC3202&fileName=/typescript-5.0.0-insiders.20230125.tgz"
    }
}

and then running npm install.

---

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.0.0-pr-52403-9".;

[typescript-bot]

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/52403/merge:

Everything looks good!

[typescript-bot]

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/52403/merge:

Something interesting changed - please have a look.

Details

webpack

tsconfig.types.json

• [MISSING] error TS7034: Variable 'serializerEntry' implicitly has type 'any' in some locations where its type cannot be determined.
  • lib/serialization/ObjectMiddleware.js#L680
• [MISSING] error TS7005: Variable 'serializerEntry' implicitly has an 'any' type.
  • lib/serialization/ObjectMiddleware.js#L687

[jakebailey]

Of course the above implies I forgot to rerun the top tests after tacking on my extra commit. Sigh.