fix(51521): Using a of property declared after an initializing constructor triggers an assertion failure in JS by a-tarasyuk · Pull Request #51524 · microsoft/TypeScript

a-tarasyuk · 2022-11-14T20:20:26Z

src/compiler/checker.ts

jakebailey

Given this change is now restricted to the binder, should the changes to the checker be reverted?

FWIW I sent a fix for this that was completely different and probably worse (#52321), thinking #39704 was the issue for this.

src/compiler/checker.ts

DanielRosenwasser · 2023-01-20T06:32:31Z

@typescript-bot pack this

I feel odd about this change - not binding feels like the wrong thing. The attempt to do JS inference in the first place is the wrong thing.

typescript-bot · 2023-01-20T06:32:34Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 9dc7b92. You can monitor the build here.

typescript-bot · 2023-01-20T06:34:23Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/143279/artifacts?artifactName=tgz&fileId=B54BE1A540768A22EEBAE0C1294C666A8C3117398A1057802D384A6FC74A1D6302&fileName=/typescript-5.0.0-insiders.20230120.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.0.0-pr-51524-2".;

DanielRosenwasser · 2023-01-20T06:46:23Z

In fact, I think this causes other issues. If you open the built playground, switch to a JS file, paste in the code, and request diagnostics, you will get the following stack trace.

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'flags')
    at checkVariableLikeDeclaration (tsWorker.js:68839:20)
    at checkPropertyDeclaration (tsWorker.js:67050:9)
    at checkSourceElementWorker (tsWorker.js:71357:20)
    at checkSourceElement (tsWorker.js:71322:11)
    at forEach (tsWorker.js:91:26)
    at checkClassDeclaration (tsWorker.js:70040:9)
    at checkSourceElementWorker (tsWorker.js:71495:20)
    at checkSourceElement (tsWorker.js:71322:11)
    at forEach (tsWorker.js:91:26)
    at checkSourceFileWorker (tsWorker.js:71680:11)

Fuller Stack

checkVariableLikeDeclaration (tsWorker.js:68839)
checkPropertyDeclaration (tsWorker.js:67050)
checkSourceElementWorker (tsWorker.js:71357)
checkSourceElement (tsWorker.js:71322)
forEach (tsWorker.js:91)
checkClassDeclaration (tsWorker.js:70040)
checkSourceElementWorker (tsWorker.js:71495)
checkSourceElement (tsWorker.js:71322)
forEach (tsWorker.js:91)
checkSourceFileWorker (tsWorker.js:71680)
checkSourceFile (tsWorker.js:71647)
checkSourceFileWithEagerDiagnostics (tsWorker.js:71741)
getDiagnosticsWorker (tsWorker.js:71749)
getDiagnostics2 (tsWorker.js:71726)
(anonymous) (tsWorker.js:97890)
runWithCancellationToken (tsWorker.js:97863)
getBindAndCheckDiagnosticsForFileNoCache (tsWorker.js:97878)
getAndCacheDiagnostics (tsWorker.js:98153)
getBindAndCheckDiagnosticsForFile (tsWorker.js:97875)
getSemanticDiagnosticsForFile (tsWorker.js:97872)
getDiagnosticsHelper (tsWorker.js:97811)
getSemanticDiagnostics (tsWorker.js:97824)
getSemanticDiagnostics (tsWorker.js:112356)
getSemanticDiagnostics (tsWorker.js:171771)

Can you make your test request errors as well?

jakebailey · 2023-01-20T06:59:01Z

Hmm, maybe #52321 is better if not binding is not preferable? (Tomorrow I'll grab this test and see)

DanielRosenwasser · 2023-01-20T07:02:57Z

A playground should be ready shortly to try out. If you get to this before Jake does, feel free to cherry-pick the commit.

Old

… crashes in checker

jakebailey

Rechecked this against the tsreplay for the babel example and it does pass. This fix seems to be the best one?

a-tarasyuk · 2023-01-20T19:32:15Z

@jakebailey What is tsreplay?

jakebailey · 2023-01-20T20:21:47Z

@jakebailey What is tsreplay?

See the expando here, for example: #52317 (comment)

DanielRosenwasser · 2023-01-20T20:54:50Z

@typescript-bot perf test this faster

typescript-bot · 2023-01-20T20:54:53Z

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 7cd7628. You can monitor the build here.

Update: The results are in!

DanielRosenwasser · 2023-01-20T20:55:36Z

@typescript-bot user test tsserver
@typescript-bot test tsserver top100

typescript-bot · 2023-01-20T20:55:38Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at 7cd7628. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-20T20:55:38Z

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at 7cd7628. You can monitor the build here.

Update: The results are in!

DanielRosenwasser

Approved pending reasonable perf and test results.

typescript-bot · 2023-01-20T21:05:49Z

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/51524/merge:

Everything looks good!

typescript-bot · 2023-01-20T21:21:42Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..51524

_Metric	_main	₅₁₅₂₄	_Delta	_Best	_Worst
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{358,182k (± 0.01%)}	_{358,230k (± 0.01%)}	_{+48k (+ 0.01%)}	_358,178k	_358,297k
_{Parse Time}	_{4.12s (± 0.42%)}	_{4.11s (± 0.40%)}	_{-0.00s (- 0.11%)}	_4.09s	_4.13s
_{Bind Time}	_{1.24s (± 1.06%)}	_{1.24s (± 0.64%)}	_{-0.00s (- 0.07%)}	_1.23s	_1.25s
_{Check Time}	_{9.50s (± 0.41%)}	_{9.49s (± 0.37%)}	_{-0.01s (- 0.15%)}	_9.44s	_9.53s
_{Emit Time}	_{8.07s (± 0.56%)}	_{8.05s (± 0.35%)}	_{-0.02s (- 0.23%)}	_8.01s	_8.08s
_{Total Time}	_{22.93s (± 0.40%)}	_{22.89s (± 0.22%)}	_{-0.04s (- 0.15%)}	_22.82s	_22.95s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{194,893k (± 0.72%)}	_{194,263k (± 0.10%)}	_{-630k (- 0.32%)}	_193,971k	_194,445k
_{Parse Time}	_{1.80s (± 0.21%)}	_{1.80s (± 0.70%)}	_{+0.00s (+ 0.22%)}	_1.79s	_1.82s
_{Bind Time}	_{0.84s (± 1.15%)}	_{0.84s (± 0.65%)}	_{-0.00s (- 0.36%)}	_0.83s	_0.85s
_{Check Time}	_{10.37s (± 0.26%)}	_{10.30s (± 0.80%)}	_{-0.07s (- 0.67%)}	_10.21s	_10.42s
_{Emit Time}	_{3.04s (± 0.98%)}	_{3.16s (± 5.73%)}	_{+0.12s (+ 3.86%)}	_3.01s	_3.42s
_{Total Time}	_{16.06s (± 0.26%)}	_{16.10s (± 1.01%)}	_{+0.04s (+ 0.25%)}	_15.91s	_16.36s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,248k (± 0.01%)}	_{343,248k (± 0.01%)}	_{+0k (+ 0.00%)}	_343,212k	_343,269k
_{Parse Time}	_{3.10s (± 1.09%)}	_{3.11s (± 0.77%)}	_{+0.01s (+ 0.33%)}	_3.06s	_3.12s
_{Bind Time}	_{1.09s (± 0.74%)}	_{1.09s (± 0.51%)}	_{-0.00s (- 0.10%)}	_1.09s	_1.10s
_{Check Time}	_{7.89s (± 0.28%)}	_{7.88s (± 0.43%)}	_{-0.01s (- 0.14%)}	_7.83s	_7.93s
_{Emit Time}	_{4.55s (± 0.93%)}	_{4.52s (± 0.36%)}	_{-0.04s (- 0.79%)}	_4.50s	_4.54s
_{Total Time}	_{16.63s (± 0.53%)}	_{16.59s (± 0.26%)}	_{-0.04s (- 0.23%)}	_16.53s	_16.65s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,667k (± 0.01%)}	_{299,653k (± 0.00%)}	_{-14k (- 0.00%)}	_299,634k	_299,664k
_{Parse Time}	_{2.45s (± 1.11%)}	_{2.42s (± 0.92%)}	_{-0.02s (- 0.89%)}	_2.40s	_2.45s
_{Bind Time}	_{1.27s (± 0.48%)}	_{1.27s (± 0.88%)}	_{+0.00s (+ 0.13%)}	_1.25s	_1.28s
_{Check Time}	_{7.47s (± 0.37%)}	_{7.47s (± 0.28%)}	_{+0.01s (+ 0.11%)}	_7.45s	_7.51s
_{Emit Time}	_{4.23s (± 0.41%)}	_{4.24s (± 0.88%)}	_{+0.01s (+ 0.29%)}	_4.19s	_4.29s
_{Total Time}	_{15.41s (± 0.29%)}	_{15.41s (± 0.42%)}	_{-0.00s (- 0.01%)}	_15.30s	_15.47s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{475,380k (± 0.00%)}	_{475,353k (± 0.01%)}	_{-27k (- 0.01%)}	_475,303k	_475,393k
_{Parse Time}	_{3.62s (± 0.35%)}	_{3.63s (± 0.54%)}	_{+0.01s (+ 0.34%)}	_3.60s	_3.65s
_{Bind Time}	_{1.00s (± 0.74%)}	_{1.00s (± 0.55%)}	_{-0.00s (- 0.13%)}	_1.00s	_1.01s
_{Check Time}	_{17.96s (± 0.37%)}	_{17.96s (± 0.39%)}	_{+0.00s (+ 0.01%)}	_17.90s	_18.09s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{22.58s (± 0.31%)}	_{22.59s (± 0.36%)}	_{+0.01s (+ 0.05%)}	_22.53s	_22.74s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{544,595k (± 0.03%)}	_{544,527k (± 0.03%)}	_{-68k (- 0.01%)}	_544,373k	_544,730k
_{Parse Time}	_{4.58s (± 0.70%)}	_{4.57s (± 0.35%)}	_{-0.01s (- 0.16%)}	_4.54s	_4.58s
_{Bind Time}	_{1.78s (± 0.23%)}	_{1.78s (± 0.33%)}	_{-0.00s (- 0.05%)}	_1.77s	_1.78s
_{Check Time}	_{2.96s (± 0.52%)}	_{2.94s (± 0.83%)}	_{-0.01s (- 0.48%)}	_2.91s	_2.97s
_{Emit Time}	_{0.09s (± 0.13%)}	_{0.09s (± 0.27%)}	_{+0.00s (+ 0.13%)}	_0.09s	_0.09s
_{Total Time}	_{9.40s (± 0.47%)}	_{9.38s (± 0.22%)}	_{-0.02s (- 0.26%)}	_9.35s	_9.41s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₁₅₂₄	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

jakebailey · 2023-01-20T22:43:13Z

Perf looks good; merging.

typescript-bot · 2023-01-20T23:02:35Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/51524/merge:

Everything looks good!

typescript-bot assigned navya9singh Nov 14, 2022

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Nov 14, 2022

DanielRosenwasser reviewed Nov 14, 2022

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

DanielRosenwasser requested a review from sandersn November 14, 2022 20:31

DanielRosenwasser reviewed Nov 14, 2022

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

sandersn requested changes Dec 5, 2022

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

This was referenced Jan 20, 2023

Fix debug assert in getConstructorDefinedThisAssignmentTypes #52321

Closed

TS Server fatal error: Debug Failure. False expression. #39704

Closed

jakebailey previously approved these changes Jan 20, 2023

View reviewed changes

jakebailey reviewed Jan 20, 2023

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

jakebailey requested a review from sandersn January 20, 2023 05:56

jakebailey mentioned this pull request Jan 20, 2023

Use a const type parameter for Object.freeze. #52317

Closed

a-tarasyuk force-pushed the fix/51521 branch from ccba7d1 to 23681f3 Compare January 20, 2023 14:28

set value declaration for ambient declarations in javascript to avoid…

b7d8b30

… crashes in checker

a-tarasyuk force-pushed the fix/51521 branch from f00bc36 to 7789f54 Compare January 20, 2023 15:27

add tests

7cd7628

a-tarasyuk force-pushed the fix/51521 branch from 7789f54 to 7cd7628 Compare January 20, 2023 15:30

jakebailey approved these changes Jan 20, 2023

View reviewed changes

sandersn approved these changes Jan 20, 2023

View reviewed changes

DanielRosenwasser approved these changes Jan 20, 2023

View reviewed changes

jakebailey merged commit 1d81c1d into microsoft:main Jan 20, 2023

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Conversation

a-tarasyuk commented Nov 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakebailey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DanielRosenwasser commented Jan 20, 2023

Uh oh!

typescript-bot commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielRosenwasser commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Jan 20, 2023

Uh oh!

DanielRosenwasser commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey left a comment

Choose a reason for hiding this comment

Uh oh!

a-tarasyuk commented Jan 20, 2023

Uh oh!

jakebailey commented Jan 20, 2023

Uh oh!

DanielRosenwasser commented Jan 20, 2023

Uh oh!

typescript-bot commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielRosenwasser commented Jan 20, 2023

Uh oh!

typescript-bot commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielRosenwasser left a comment

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Jan 20, 2023

Uh oh!

typescript-bot commented Jan 20, 2023

Uh oh!

jakebailey commented Jan 20, 2023

Uh oh!

typescript-bot commented Jan 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

typescript-bot commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading

DanielRosenwasser commented Jan 20, 2023 •

edited

Loading

DanielRosenwasser commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading

typescript-bot commented Jan 20, 2023 •

edited

Loading