Report aggregate statistics for solution as well as some solution perf numbers#50267
Merged
sheetalkamat merged 5 commits intomainfrom Aug 11, 2022
Merged
Report aggregate statistics for solution as well as some solution perf numbers#50267sheetalkamat merged 5 commits intomainfrom
sheetalkamat merged 5 commits intomainfrom
Conversation
…f numbers This change under --extendedDiagnostics aggregates the diagnostics from all projects built and reports it at the end. Apart from that it also outputs some measurements for work that happens in tsc --build like finding if projects are uptodate etc. Also removes unnecessary node count per suggestion
typescript-bot
added
the
For Uncommitted Bug
Member
Author
|
@typescript-bot pack this |
rbuckton
suggested changes
Aug 11, 2022
| const { performance: nodePerformance, PerformanceObserver } = require("perf_hooks") as typeof import("perf_hooks"); | ||
| if (hasRequiredAPI(nodePerformance, PerformanceObserver)) { | ||
| performance = nodePerformance; | ||
| if (hasRequiredAPI(nodePerformance as unknown as Performance, PerformanceObserver)) { |
Contributor
There was a problem hiding this comment.
Is this because our reference to @types/node is out of date? clearMeasures was added in NodeJS v16.7.0.
Member
Author
There was a problem hiding this comment.
Yes its because of our @types/node
Contributor
There was a problem hiding this comment.
Any reason we shouldn't update our local copy of @types/node to at least v16?
sheetalkamat
commented
Aug 11, 2022
Co-authored-by: Ron Buckton <ron.buckton@microsoft.com>
Member
|
Nit: Up-to-date check time time |
amcasey
approved these changes
Aug 11, 2022
Member
amcasey
left a comment
amcasey
left a comment
There was a problem hiding this comment.
I didn't read the code change (which I assume is largely as before), but I like the output.
rbuckton
approved these changes
Aug 11, 2022
Contributor
rbuckton
left a comment
rbuckton
left a comment
There was a problem hiding this comment.
This looks fine, though we may want to consider updating our @types/node definitions to at least v16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change under
--extendedDiagnosticsaggregates the diagnostics from all projects built and reports it at the end. Apart from that it also outputs some measurements for work that happens in tsc --build like finding if projects are uptodate etc.Also removes unnecessary node count per suggestion by @amcasey
Different work per suggestion by @rbuckton in #49285