Skip to content

Comments

Handle if plugin doesnt specify name#42717

Merged
sheetalkamat merged 1 commit intomasterfrom
pluginWithoutName
Feb 9, 2021
Merged

Handle if plugin doesnt specify name#42717
sheetalkamat merged 1 commit intomasterfrom
pluginWithoutName

Conversation

@sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Feb 9, 2021 •
edited
Loading

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 9, 2021
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Feb 9, 2021

@typescript-bot cherry-pick this to release-3.1
@typescript-bot cherry-pick this to release-3.7
@typescript-bot cherry-pick this to release-3.9
@typescript-bot cherry-pick this to release-4.0
@typescript-bot cherry-pick this to release-4.1

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 00c7923. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-3.1 on this PR at 00c7923. You can monitor the build here.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Feb 9, 2021

@typescript-bot cherry-pick this to release-3.9

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-3.7 on this PR at 00c7923. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-3.9 on this PR at 00c7923. You can monitor the build here.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Feb 9, 2021

@typescript-bot cherry-pick this to release-4.1

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.0 on this PR at 00c7923. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.1 on this PR at 00c7923. You can monitor the build here.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Feb 9, 2021

@typescript-bot cherry-pick this to release-4.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.0 on this PR at 00c7923. You can monitor the build here.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Feb 9, 2021

@typescript-bot cherry-pick this to release-3.7

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-3.7 on this PR at 00c7923. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.7 manually.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.1 manually.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.9 manually.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.1 manually.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.0 manually.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.0 manually.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.7 manually.

@DanielRosenwasser DanielRosenwasser mentioned this pull request Feb 9, 2021
Closed
@typescript-bot typescript-bot removed the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 9, 2021
@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Feb 9, 2021
@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021 •
edited
Loading

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/95408/artifacts?artifactName=tgz&fileId=856D2799D959091E670795C14F53C2CE877BAB90B988B7059E14F845C679DB4502&fileName=/typescript-4.2.0-insiders.20210209.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.2.0-pr-42717-20".;

@sheetalkamat
Copy link
Member Author

sheetalkamat commented Feb 9, 2021

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021 •
edited
Loading

Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 925aba6. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021 •
edited
Loading

Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/95428/artifacts?artifactName=tgz&fileId=54D0A58731F6BF36808A94641FA908BB7A53D7957C08BDA91160C83585A4D63802&fileName=/typescript-4.2.0-insiders.20210209.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.2.0-pr-42717-23".;

@sheetalkamat sheetalkamat merged commit 5280ba4 into master Feb 9, 2021
@sheetalkamat sheetalkamat deleted the pluginWithoutName branch February 9, 2021 23:23
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@minestarks minestarks Awaiting requested review from minestarks

@mjbvz mjbvz Awaiting requested review from mjbvz

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees

@sheetalkamat sheetalkamat

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle plugins without specified names TS Server fatal error: Cannot read property 'indexOf' of undefined

3 participants

@sheetalkamat @DanielRosenwasser @typescript-bot