Fix use-before-def errors for ESNext property declarations

[sandersn]

Fixes #36441
Fixes #36442

[andrewbranch]

For some reason my brain wants this expression to be De Morgan’d, or maybe for whole function itself to return use-before-declared, not declared-before-used. Oh well.

[sandersn]

the WHOLE time I was working on this, except every change made things harder to read.

[andrewbranch]

I bet this condition actually could be the same as isValidTypeOnlyAliasUseSite. But probably not worth changing.

[andrewbranch]

I can’t quite figure out what this means without stepping through one case that needs stopAtAllPropertyDeclarations as true and one that needs false, but are there any tests with a class expression as the initializer of a property declaration?

class Foo {
  Bar = class extends Foo {
    p2 = this.p1
  }
  p1 = 0
}

(I don’t know, maybe there’s a more creative combo of these horrors)

[sandersn]

There is one:

class B2<V> {
    anon = class extends A<V> { }
}

Your example works on 3.7, so needs to keep working on 3.8:

https://www.typescriptlang.org/play/index.html#code/MYGwhgzhAECC0G8BQ1XQELQLzVJGApgB4AuBAdgCYzzJr3QAOATNtCQBYCWEAdIwEYUaAL7DUgtgAYkYgG5gATtDBtyBAO5wAFAEokwAPbkIhkAV4hDAc21h+A-QuVgARms0re6PQeOnzSxs7Vwd9IA

Back to the drawing board I guess. What a test case!

[andrewbranch]

Commit to fix this looks good 👍