feat(lib/es2015): Add typed overloads to Reflect#35608
feat(lib/es2015): Add typed overloads to Reflect#35608sandersn merged 2 commits intomicrosoft:mainfrom
Reflect#35608Conversation
src/lib/es2015.reflect.d.ts
Outdated
| * @param argumentsList An array of argument values to be passed to the function. | ||
| */ | ||
| function apply<T, A extends any[], R>(target: (this: T, ...args: A) => R, thisArgument: T, argumentsList: A): R; | ||
| function apply(target: (...args: any) => any, thisArgument: any, argumentsList: ArrayLike<any>): any; |
There was a problem hiding this comment.
This second overload will just be picked by the compiler whenever anything fails to be accepted by the first overload, so this doesn't really add strictness. Better autocomplete, I guess.
There was a problem hiding this comment.
Unfortunately, this is needed to be able to pass the arguments object.
src/lib/es2015.reflect.d.ts
Outdated
| * @param newTarget The constructor to be used as the `new.target` object. | ||
| */ | ||
| function construct<A extends any[], R>(target: new (...args: A) => R, argumentsList: A, newTarget?: new (...args: any) => any): R; | ||
| function construct(target: new (...args: any) => any, argumentsList: ArrayLike<any>, newTarget?: new (...args: any) => any): any; |
There was a problem hiding this comment.
Same here, the second overload makes the first one useless 😢
typescript-bot
added
For Uncommitted Bug
ExE-Boss
force-pushed
the
lib/es2015/typed-reflect
branch
from
6901942 to
ea136c0
Compare
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
ExE-Boss
force-pushed
the
lib/es2015/typed-reflect
branch
from
ea136c0 to
902a77d
Compare
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
This seems like a reasonable improvement that wouldn't break anything obvious because it leaves the originals behind as overloads. I did a quick sample of usage and Reflect is used sparingly across many prominent packages, so I think we'd notice problems after merging if there were going to be any.
However, I'd like to get the opinion of one other team member before merging, since lib changes nearly always have hidden gotches. @andrewbranch or @rbuckton can you give your opinion?
4 participants
This adds typed overloads to
Reflect, similar to whatstrictBindCallApplydoes.I’ve also corrected the type of(extracted into #41987)getPrototypeOf(…)andsetPrototypeOf(…).Depends on:
Reflect.enumerate(…)#38967 (merged)Reflectmethods #41987 (merged)