When a packed version of TypeScript is requested, request a build of Monaco#33536
When a packed version of TypeScript is requested, request a build of Monaco#33536orta merged 1 commit intomicrosoft:masterfrom
Conversation
…t to create a build of monaco for the playground
|
Why not just amend the end of the tarball build pipeline to also fire off a Monaco build? |
|
I mean, I guess this effectively does that. Eh, may as well include it in this script, rather than the job itself, I suppose. But! You should include the tarball url in a query param/environment var, rather than trying to scrape the comment after getting the request, imo. |
|
I wish I could send the actual URL, there's a limit to how many characters I can send (100 max) and the UUIDs basically eat all of that. Even after dropping all the args + urls which I could infer on the other size I couldn't get it safely under that number. I'm happy moving it anywhere else though, curl will work just as well but it does rely on reading those comments so it kinda needs to be sure it was posted. Perhaps I can add it as an extra step in the azure devops job? |
Yick. Can you include more characters as a POST body, rather than a GET query param? |
Naaaah, this is fine. It's only used as the last stage of that job, anyway. |
|
Nope, the request fails if you include anything other than that 100 char string, tried a few ways to get info between them but in the end this the most stateless/decoupled way I could think of |
This adds a hook to trigger the generation of a build of Monaco-typescript and Monaco-editor from the pack comment inside the TS repo.
Here's an example build which I triggered pretending it was coming from #33290
All the deploy work is explained in https://github.com/orta/make-monaco-builds/