Improved parameter names for call signatures resulting from unions#32056
Merged
weswigham merged 1 commit intomicrosoft:masterfrom Jul 11, 2019
Merged
Conversation
…en only one parameter name is available.
I chuckled a bit at this filename, not sure why. |
Contributor
Author
|
@fatcerberus It was there when I started, it amused me too 😄 |
Contributor
Author
|
@weswigham Any thought on this PR since it touches your code ? The issue was that if the methods had different parameter length The fix was to use the name of the parameter in the function with more parameters. |
weswigham
approved these changes
Jul 11, 2019
Member
weswigham
left a comment
There was a problem hiding this comment.
Seems like an improvement to me ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31845