Skip to content

Comments

Correct outline hint spans for functions#31865

Merged
uniqueiniquity merged 2 commits intomicrosoft:masterfrom
amcasey:FunctionHintSpan
Jun 12, 2019
Merged

Correct outline hint spans for functions#31865
uniqueiniquity merged 2 commits intomicrosoft:masterfrom
amcasey:FunctionHintSpan

Conversation

@amcasey
Copy link
Member

@amcasey amcasey commented Jun 12, 2019

The hint span is the range shown in the preview for a collapsed region. We were showing one element too high up the tree.

@amcasey
Copy link
Member Author

amcasey commented Jun 12, 2019

@RyanCavanaugh We're still confirming, but we think this bug may be seriously degrading scrolling perf in large files in VS.

@gundermanc
Copy link

I can confirm on a test sample that this fixes a visual issue in the placement of structure guides.

@uniqueiniquity uniqueiniquity merged commit 0628adc into microsoft:master Jun 12, 2019
@amcasey amcasey deleted the FunctionHintSpan branch June 12, 2019 17:14
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants