Check to make sure default npm exists at path before trying to use it#30910
Merged
RyanCavanaugh merged 3 commits intomicrosoft:masterfrom Apr 18, 2019
Merged
Check to make sure default npm exists at path before trying to use it#30910RyanCavanaugh merged 3 commits intomicrosoft:masterfrom
RyanCavanaugh merged 3 commits intomicrosoft:masterfrom
Conversation
**Bug** If the typings installer is run under a copy of node that does not include npm—but on a machine that does have npm installed—it will incorrectly try to use the npm that does not exist next to its running version of node **Fix** Make sure that we check that npm we select exists before trying to use it as the default. Otherwise, fall back to using plain old `npm`
sheetalkamat
approved these changes
Apr 15, 2019
sheetalkamat
requested changes
Apr 15, 2019
Member
sheetalkamat
left a comment
sheetalkamat
left a comment
There was a problem hiding this comment.
#24425 reverted this exact change since it breaks VS
Member
|
@sheetalkamat I checked my mail box and chat histories but couldn't find anything about ATA from last May. I'm not sure I was involved. |
Contributor
Author
|
@amcasey Would old VS Versions still be broken though? Can we perhaps pass in a command line flag to enable this new behavior? |
Member
|
@mjbvz Good catch - yes, it would have to be behind a flag (assuming it works now). |
sheetalkamat
approved these changes
Apr 15, 2019
RyanCavanaugh
pushed a commit
to RyanCavanaugh/TypeScript
that referenced
this pull request
Apr 18, 2019
…microsoft#30910) * Check to make sure default npm exists at path before trying to use it **Bug** If the typings installer is run under a copy of node that does not include npm—but on a machine that does have npm installed—it will incorrectly try to use the npm that does not exist next to its running version of node **Fix** Make sure that we check that npm we select exists before trying to use it as the default. Otherwise, fall back to using plain old `npm` * Add command line flag to gate new behavior * Fix missing semicolon
RyanCavanaugh
added a commit
that referenced
this pull request
Apr 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
If the typings installer is run under a copy of node that does not include npm—but on a machine that does have npm installed—it will incorrectly try to use the npm that does not exist next to its running version of node
Fix
Make sure that we check that npm we select exists before trying to use it as the default. Otherwise, fall back to using plain old
npmFixes #30909