Fix #4260 : Allow arguments that accept void to be omitted#27506
Closed
jack-williams wants to merge 4 commits intomicrosoft:masterfrom
Closed
Fix #4260 : Allow arguments that accept void to be omitted#27506jack-williams wants to merge 4 commits intomicrosoft:masterfrom
jack-williams wants to merge 4 commits intomicrosoft:masterfrom
Conversation
Member
|
@typescript-bot test this |
Collaborator
|
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at f3b6eea. You can monitor the build here. It should now contribute to this PR's status checks. |
Collaborator
Author
|
@RyanCavanaugh There were some upstream changes that affected the error messages so I merged master to get the new baselines; I don’t know if this had any impact on the RWC. Not a huge fan of having intermediate broken commits, and a merge, in the history. Tomorrow I might reopen this with a new PR that has a tidy history. |
Collaborator
Author
|
@RyanCavanaugh Closing in favour of #27522 (If I was better with git I could probably rebase through the merge commit, but sadly, I'm not). Please mark as irrelevant/invalid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4260
Not sure if this behaviour is still desired anymore, but I thought I'd at least put this out there to try out.
I tried doing a fix that worked for generic types:
but things went horribly wrong, mostly because you have to defer the check until after instantiation and it messes with overload resolution. In the end it really didn't seem worth it.