Conversation
ghost
requested review from
mhegazy
approved these changes
Feb 6, 2018
ghost
pushed a commit
that referenced
this pull request
Feb 6, 2018
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of creating
CompletionInfodirectly, return a union of several kinds and convert toCompletionInfoat the end. This is useful because we won't always want aCompletionInfo(#21374). It also cuts down on code since we were duplicating the code to createCompletionInfoin a lot of places.Note: Previously,
getStringLiteralCompletionEntriesFromCallExpressionreturnedisNewIdentifierLocation: true, butisNewIdentifierLocation: falsereturnedisNewIdentifierLocation: false. In both cases, we are getting the string literal from a contextual type, so I would expect these situations to work the same, and now we returnisNewIdentifierLocation: truein both locations. Relevant testcompletionForStringLiteral3which tests for this was added in #8428. @mhegazy