Do not treat local resolution of require call as external module#11370
Merged
sheetalkamat merged 4 commits intomasterfrom Oct 17, 2016
Merged
Do not treat local resolution of require call as external module#11370sheetalkamat merged 4 commits intomasterfrom
sheetalkamat merged 4 commits intomasterfrom
Conversation
Return type of require call is from external module resolution only if it doesnt resolve to local module Fixes #10931
mhegazy
reviewed
Oct 13, 2016
src/compiler/checker.ts
Outdated
| if (isInJavaScriptFile(node) && | ||
| isRequireCall(node, /*checkArgumentIsStringLiteral*/true) && | ||
| // Make sure require is not a local function | ||
| !resolveName(node.expression, (<Identifier>node.expression).text, SymbolFlags.Value | SymbolFlags.ExportValue, /*nameNotFoundMessage*/ undefined, /*nameArg*/ undefined)) { |
Contributor
There was a problem hiding this comment.
why do you need the ExportValue is not Value enough?
Member
Author
There was a problem hiding this comment.
Just to make sure it behaves similar to resolving identifier though its not really needed, I just like to keep it in sync with it
Contributor
There was a problem hiding this comment.
when would it find an ExportValue that is not an Value?
mhegazy
approved these changes
Oct 17, 2016
This was referenced Oct 20, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind the source file as external module only if not already done
Return type of require call is from external module resolution only if it doesn't resolve to local module
Fixes #10931
Note that we cannot fully guarantee that things will work perfectly because by the time we know that require is not a local symbol it is too late since the source file binding has already happened as external module. This is just little better handling in few cases like #10931