[Release 2.0] fix10289: correctly generate tsconfig.json with --lib#10310
Closed
yuit wants to merge 6 commits intorelease-2.0from
Closed
[Release 2.0] fix10289: correctly generate tsconfig.json with --lib#10310yuit wants to merge 6 commits intorelease-2.0from
yuit wants to merge 6 commits intorelease-2.0from
Conversation
src/compiler/commandLineParser.ts
Outdated
| } | ||
| } | ||
|
|
||
| function getKeyOfCompilerOptionValue(value: CompilerOptionsValue, customTypeMap: Map<string | number>): string | undefined { |
Member
There was a problem hiding this comment.
stray space after "use it"
Contributor
Author
|
The failure is due to the fact that "release-2.0" has dependency on TypeScript nightly which has Map/MapLike optimization |
Contributor
Author
|
I am going to close this one and open a new one for master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #10289