Conversation
Contributor
Got false positives?Make changes to the global settings spellcheck.json in /artsy/peril-settings. Typos for target.md
Typos for strict.md
Typos for sourceMap.md
Typos for outFile.md
Typos for outDir.md
Typos for out.md
Typos for noImplicitUseStrict.md
Typos for lib.md
Typos for isolatedModules.md
Typos for inlineSourceMap.md
Typos for importHelpers.md
Typos for downlevelIteration.md
Typos for charset.md
Typos for README.md
Typos for README.md
Lighthouse Scores
|
| Performance | Accessibility | Best Practices | SEO | Progressive Web App |
|---|---|---|---|---|
| 0.98 | 0.85 | 0.93 | 0.82 | 0.52 |
/tsconfig
| Performance | Accessibility | Best Practices | SEO | Progressive Web App |
|---|---|---|---|---|
| 0.92 | 0.9 | 1 | 0.8 | 0.52 |
/docs/handbook/integrating-with-build-tools.html
| Performance | Accessibility | Best Practices | SEO | Progressive Web App |
|---|---|---|---|---|
| 0.97 | 0.9 | 1 | 0.71 | 0.52 |
Snapshots updated
backstop_default_TSConfig_Example_0_viewport_0_phone.png
| Before | After |
|---|---|
![]() |
![]() |
backstop_default_TSConfig_Example_0_viewport_1_tablet.png
| Before | After |
|---|---|
![]() |
![]() |
backstop_default_TSConfig_Example_0_viewport_2_computer.png
| Before | After |
|---|---|
![]() |
![]() |
Contributor
Author
|
This one is non-controversial |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Moves in existing copy for TSConfig examples, doesn't touch them, will keep that new repo as source of truth until this feels presentable.
Interesting aside: There are three competing standards for how we could do metadata for code samples.
// @somethinginside the code