fix: remove extraneous declaration in relatedTo#1095
Merged
orta merged 1 commit intomicrosoft:v2from Sep 18, 2020
Merged
Conversation
- it was specified twice, once grouped with types and typeRoots for some
reason and missing declarationDir
- so remove that one, leave in the one that has both declarationDir
_and_ emitDeclarationOnly
- second one that remains is ~5 lines below this
This was referenced Sep 17, 2020
Contributor
|
👍🏻 thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
reason and missing declarationDir
and emitDeclarationOnly
TypeScript-Website/packages/tsconfig-reference/scripts/tsconfigRules.ts
Line 80 in 2ab62ad
Tags
Stumbled upon this after writing #971
This seems to have been erroneously added in #163 here
Screenshot
Currently the first one supersedes the second one, so
declarationDirisn't mentioned as related on the website: