New GitHubRepositoryBranchProtectionRule Functions#255
Merged
HowardWolosky merged 15 commits intomicrosoft:masterfrom Jul 31, 2020
Merged
New GitHubRepositoryBranchProtectionRule Functions#255HowardWolosky merged 15 commits intomicrosoft:masterfrom
HowardWolosky merged 15 commits intomicrosoft:masterfrom
Conversation
8 tasks
HowardWolosky
added
api completeness
X-Guardian
force-pushed
the
GitHubRepositoryBranchProtection
branch
from
a869092 to
cdc1cdb
Compare
HowardWolosky
suggested changes
Jul 2, 2020
Contributor
HowardWolosky
left a comment
HowardWolosky
left a comment
There was a problem hiding this comment.
Looks like we still have some unresolved thoughts from the previous version of this PR that we can continue here.
HowardWolosky
added
the
waiting for update
X-Guardian
force-pushed
the
GitHubRepositoryBranchProtection
branch
from
9e3a85b to
794a8bb
Compare
Contributor
|
/azp run PowerShellForGitHub-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@HowardWolosky, this is ready for the next review. |
X-Guardian
force-pushed
the
GitHubRepositoryBranchProtection
branch
from
8b329b0 to
b6bb240
Compare
Contributor
|
/azp run PowerShellForGitHub-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
HowardWolosky
suggested changes
Jul 30, 2020
Contributor
HowardWolosky
left a comment
HowardWolosky
left a comment
There was a problem hiding this comment.
Making this New instead of Set certainly simplified this substantially.
Just a couple small observations and this should be good to merge.
Thanks!
Contributor
|
/azp run PowerShellForGitHub-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
HowardWolosky
removed
the
waiting for update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following GitHub Branch Protection Rule functions to the
GitHubBranchesmodule:Get-GitHubRepositoryBranchProtectionRuleNew-GitHubRepositoryBranchProtectionRuleRemove-GitHubRepositoryBranchProtectionRuleThe
lukeCageAcceptHeaderwas also added to theGitHubCoremodule with a value ofapplication/vnd.github.luke-cage-preview+json.Issues Fixed
None
References
GitHub REST API v3
Checklist
If desired, ensure your name is added to our Contributors list