Add confirmation prompts and examples for Remove- functions

[giuseppecampanelli]

Fixes #171

[msftclas]

All CLA requirements met.

[HowardWolosky]

Thanks so much for this, @themilanfan!

Really minor feedback to address, and then I'll be happy to merge this in. Thanks again, and welcome to the project!

[HowardWolosky]

Actually, just realized that you didn't add the necessary ShouldProcess commands to have any impact here.

See

PowerShellForGitHub/GitHubProjects.ps1

Line 496 in d279f1c

if ($PSCmdlet.ShouldProcess($project, "Remove project"))

You probably need to update a bunch of tests too in order for them to pass (adding -Confirm:$false to those calls), because once this is done, all of the existing tests that make use of Remove-* commands will fail because they'll hang waiting for user confirmation.

[giuseppecampanelli]

@HowardWolosky thank you for the feedback, I've just committed the changes!

[giuseppecampanelli]

Completed in new commits

[giuseppecampanelli]

Completed review in commits

[giuseppecampanelli]

@HowardWolosky I'm not sure what's happening with the check, I reviewed all the changes you requested and thought it would resume

[HowardWolosky]

@themilanfan - Thanks for the update. Will review the changes this weekend.

As for the checks, ignore them for now. I've been running into issues with the tests properly running in PR CI builds, so I still need to verify them locally before merging. I'll get to fixing the PR CI build at some point.

[HowardWolosky]

Overall, this looks like a great update, thanks!
One minor documentation suggestion in this review.
Additionally, more tests have been added since you authored this PR. Would you be willing to refresh this PR with the latest changes from master, and incorporate any remaining -Confirm:$false parameters into any new instances of Remove-* methods being called in the tests?

Thanks so much!

[giuseppecampanelli]

Hi @HowardWolosky, I've added the remaining -Confirm:$false as well as updated the documentation and fixed another small issue in GitHubLabels.tests.ps1 as well. I will also wait for this to merge so that for issue #176 I don't miss any Confirm:$false there.

[giuseppecampanelli]

Changes reviewed

[giuseppecampanelli]

Removed them 😄

[HowardWolosky]

It looks like some conflicts came in as a result of some of the recent commits as I've been trying to get the CI to run clean on all platforms. Can you please address the conflicts? Then I'll give it a run through the CI and get it committed....Thanks!

[giuseppecampanelli]

Resolved conflicts 😄

[HowardWolosky]

/azp run PowerShellForGitHub-CI

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[HowardWolosky]

This is ready to go. Thanks so much!