Fix handling of nullable enums for 3.0#2920
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Youssef1313
force-pushed
the
nullable-enum
branch
from
21bcff8 to
6ee0df1
Compare
DeagleGross
approved these changes
Jul 1, 2026
baywet
requested changes
Jul 2, 2026
baywet
previously approved these changes
Jul 2, 2026
baywet
left a comment
baywet
left a comment
Member
There was a problem hiding this comment.
Thank you for making the changes!
Member
Author
|
@baywet Is there anything remaining to get this merged? Would we have a new version released before .NET 11 Preview 7 so that we try to get that in aspnetcore repo and possibly build some fixes on our side on top of this? |
baywet
reviewed
Jul 3, 2026
baywet
approved these changes
Jul 3, 2026
baywet
left a comment
baywet
left a comment
Member
There was a problem hiding this comment.
Thank you for making the changes!
Merged
This was referenced Jul 6, 2026
Open
MelfusX
added a commit
to MelfusX/IncidentCompass
that referenced
this pull request
Jul 13, 2026
Updated [Microsoft.OpenApi](https://github.com/Microsoft/OpenAPI.NET) from 2.9.0 to 2.10.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.OpenApi's releases](https://github.com/Microsoft/OpenAPI.NET/releases)._ ## 2.10.0 ## [2.10.0](microsoft/OpenAPI.NET@v2.9.0...v2.10.0) (2026-07-03) ### Features * add JsonConverter for OpenApiSchema System.Text.Json serialization ([#2915](microsoft/OpenAPI.NET#2915)) ([465521b](microsoft/OpenAPI.NET@465521b)) * **library:** support schema keywords on references ([2749463](microsoft/OpenAPI.NET@2749463)), closes [#2903](microsoft/OpenAPI.NET#2903) ### Bug Fixes * Don't silently skip null assignment to OpenApiDocument.Tags ([#2917](microsoft/OpenAPI.NET#2917)) ([6a45a82](microsoft/OpenAPI.NET@6a45a82)) * handling of nullable enums for 3.0 ([#2920](microsoft/OpenAPI.NET#2920)) ([f4778e0](microsoft/OpenAPI.NET@f4778e0)) * **library:** keep v3 schema references ref-only ([8d811c3](microsoft/OpenAPI.NET@8d811c3)) * preserve JSON Schema 2020-12 keyword siblings on $ref schemas for OAS 3.1+ ([#2896](microsoft/OpenAPI.NET#2896)) ([fb20d46](microsoft/OpenAPI.NET@fb20d46)) * preserve JSON Schema 2020-12 keyword siblings on $ref schemas for OAS 3.1+ ([#2896](microsoft/OpenAPI.NET#2896)) ([c79a83e](microsoft/OpenAPI.NET@c79a83e)) * use async method for crypto flush ([677b519](microsoft/OpenAPI.NET@677b519)) Commits viewable in [compare view](microsoft/OpenAPI.NET@v2.9.0...v2.10.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Igor Lagutin <61908024+MelfusX@users.noreply.github.com>
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this scenario wasn't producing a
typeand wasn't producing a null value in the enum array.This fixes it so that they are produced.
In the future, we could also avoid adding a
oneOfwith a single element in this scenario.