JsonSchema.NET Integration#1278
Merged
MaggieKimani1 merged 225 commits intorelease/2.0.0from Nov 21, 2023
Merged
Conversation
…-json-schema-library
…eserializer and cleaning up code
…t how to perform upcasting from OpenApiSchema to JsonSchema
…/use-json-node-for-parsing"
MaggieKimani1
requested review from
baywet,
darrelmiller,
irvinesunday,
peombwa and
zengin
as code owners
darrelmiller
reviewed
Nov 7, 2023
…' into mk/integrate-json-schema-library
src/Microsoft.OpenApi.Readers/V31/OpenApiSecurityRequirementDeserializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi/Models/References/OpenApiHeaderReference.cs
Outdated
Show resolved
Hide resolved
| /// </summary> | ||
| /// <typeparam name="T"></typeparam> | ||
| public class ValidationRule<T> : ValidationRule where T : IOpenApiElement | ||
| public class ValidationRule<T> : ValidationRule |
Member
There was a problem hiding this comment.
Ugh. This is because JsonSchema doesn't implement this interface. Hmm, that seems like it is going to cause us problems.
darrelmiller
requested changes
Nov 13, 2023
Member
darrelmiller
left a comment
darrelmiller
left a comment
There was a problem hiding this comment.
It's looking good. I just added a few comments that we should address. Specifically those related to dependencies on the YAML libraries.
This was referenced Nov 15, 2023
|
SonarCloud Quality Gate failed.
|
darrelmiller
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.