fix: Don't silently skip null assignment to OpenApiDocument.Tags#2917
Merged
Conversation
Don't silently skip null assignment to OpenApiDocument.Tags
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall coverage in the branch is 41%. The coverage in the branch is 88%. Show a code coverage summary of the most impacted files.
Code Coverage is in Public Preview. Learn more and provide us with your feedback. |
|
peombwa
approved these changes
Jun 29, 2026
This was referenced Jul 6, 2026
Open
Open
github-actions Bot
pushed a commit
to EelcoLos/nx-tinkering
that referenced
this pull request
Jul 7, 2026
Pinned [Microsoft.OpenApi](https://github.com/Microsoft/OpenAPI.NET) at 2.10.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.OpenApi's releases](https://github.com/Microsoft/OpenAPI.NET/releases)._ ## 2.10.0 ## [2.10.0](microsoft/OpenAPI.NET@v2.9.0...v2.10.0) (2026-07-03) ### Features * add JsonConverter for OpenApiSchema System.Text.Json serialization ([#2915](microsoft/OpenAPI.NET#2915)) ([465521b](microsoft/OpenAPI.NET@465521b)) * **library:** support schema keywords on references ([2749463](microsoft/OpenAPI.NET@2749463)), closes [#2903](microsoft/OpenAPI.NET#2903) ### Bug Fixes * Don't silently skip null assignment to OpenApiDocument.Tags ([#2917](microsoft/OpenAPI.NET#2917)) ([6a45a82](microsoft/OpenAPI.NET@6a45a82)) * handling of nullable enums for 3.0 ([#2920](microsoft/OpenAPI.NET#2920)) ([f4778e0](microsoft/OpenAPI.NET@f4778e0)) * **library:** keep v3 schema references ref-only ([8d811c3](microsoft/OpenAPI.NET@8d811c3)) * preserve JSON Schema 2020-12 keyword siblings on $ref schemas for OAS 3.1+ ([#2896](microsoft/OpenAPI.NET#2896)) ([fb20d46](microsoft/OpenAPI.NET@fb20d46)) * preserve JSON Schema 2020-12 keyword siblings on $ref schemas for OAS 3.1+ ([#2896](microsoft/OpenAPI.NET#2896)) ([c79a83e](microsoft/OpenAPI.NET@c79a83e)) * use async method for crypto flush ([677b519](microsoft/OpenAPI.NET@677b519)) ## 2.9.0 ## [2.9.0](microsoft/OpenAPI.NET@v2.8.0...v2.9.0) (2026-06-10) ### Features * add contains/minContains/maxContains members ([fadb422](microsoft/OpenAPI.NET@fadb422)) * **library:** add missing json schema properties ([db41a3c](microsoft/OpenAPI.NET@db41a3c)) ### Bug Fixes * **library:** always copy unevaluated properties ([3951a31](microsoft/OpenAPI.NET@3951a31)) * **library:** avoid false circular refs for external schema re-exports ([a058913](microsoft/OpenAPI.NET@a058913)) * **library:** avoid false circular refs for external schema re-exports ([1bace68](microsoft/OpenAPI.NET@1bace68)) * **library:** merge contains compat members into missing properties ([7dc45e1](microsoft/OpenAPI.NET@7dc45e1)) * **library:** remove unshipped schema extension fallback ([b301827](microsoft/OpenAPI.NET@b301827)) * **library:** use version-specific schema keyword callbacks ([f93d76a](microsoft/OpenAPI.NET@f93d76a)) * **library:** use x-jsonschema schema extensions ([ec04a7f](microsoft/OpenAPI.NET@ec04a7f)) ## 2.8.0 ## [2.8.0](microsoft/OpenAPI.NET@v2.7.6...v2.8.0) (2026-06-01) ### Features * **reader:** remove ParseNode infrastructure ([d7c6a9d](microsoft/OpenAPI.NET@d7c6a9d)) * Significant performance improvements resulting ~40% reduced allocations when parsing JSON descriptions, ~25% for YAML. ## 2.7.6 ## [2.7.6](microsoft/OpenAPI.NET@v2.7.5...v2.7.6) (2026-05-28) ### Bug Fixes * **reader:** preserve nullable Null flag when type appears after nullable in V3.1/V3.2 deserializers ([288e95a](microsoft/OpenAPI.NET@288e95a)) Commits viewable in [compare view](microsoft/OpenAPI.NET@v2.7.5...v2.10.0). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Jul 13, 2026
Closed
Closed
Closed
MelfusX
added a commit
to MelfusX/IncidentCompass
that referenced
this pull request
Jul 13, 2026
Updated [Microsoft.OpenApi](https://github.com/Microsoft/OpenAPI.NET) from 2.9.0 to 2.10.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.OpenApi's releases](https://github.com/Microsoft/OpenAPI.NET/releases)._ ## 2.10.0 ## [2.10.0](microsoft/OpenAPI.NET@v2.9.0...v2.10.0) (2026-07-03) ### Features * add JsonConverter for OpenApiSchema System.Text.Json serialization ([#2915](microsoft/OpenAPI.NET#2915)) ([465521b](microsoft/OpenAPI.NET@465521b)) * **library:** support schema keywords on references ([2749463](microsoft/OpenAPI.NET@2749463)), closes [#2903](microsoft/OpenAPI.NET#2903) ### Bug Fixes * Don't silently skip null assignment to OpenApiDocument.Tags ([#2917](microsoft/OpenAPI.NET#2917)) ([6a45a82](microsoft/OpenAPI.NET@6a45a82)) * handling of nullable enums for 3.0 ([#2920](microsoft/OpenAPI.NET#2920)) ([f4778e0](microsoft/OpenAPI.NET@f4778e0)) * **library:** keep v3 schema references ref-only ([8d811c3](microsoft/OpenAPI.NET@8d811c3)) * preserve JSON Schema 2020-12 keyword siblings on $ref schemas for OAS 3.1+ ([#2896](microsoft/OpenAPI.NET#2896)) ([fb20d46](microsoft/OpenAPI.NET@fb20d46)) * preserve JSON Schema 2020-12 keyword siblings on $ref schemas for OAS 3.1+ ([#2896](microsoft/OpenAPI.NET#2896)) ([c79a83e](microsoft/OpenAPI.NET@c79a83e)) * use async method for crypto flush ([677b519](microsoft/OpenAPI.NET@677b519)) Commits viewable in [compare view](microsoft/OpenAPI.NET@v2.9.0...v2.10.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Igor Lagutin <61908024+MelfusX@users.noreply.github.com>
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
port of #2916 to v2