improvement(eslint-config-fluid): include languageOptions in printed configs #26320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de type inference
…nd VS Code type inference" This reverts commit fade927.
tylerbutler
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the ESLint config printing functionality to make parser options visible in the printed snapshots, improving debuggability of ESLint configuration changes. Previously, the entire languageOptions block was removed; now only the large globals object is excluded while retaining useful information like parser options and ecmaVersion.
Changes:
- Modified the config printing logic to selectively remove only
globalsfromlanguageOptionsinstead of removing the entirelanguageOptionsblock - Updated all 7 printed config snapshots to include the new
languageOptionssection with parser configuration details
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| common/build/eslint-config-fluid/scripts/print-configs.ts | Updated deletion logic to only remove globals from languageOptions, preserving other useful configuration like parserOptions and ecmaVersion |
| common/build/eslint-config-fluid/printed-configs/test.json | Added languageOptions section showing projectService: false and project file references |
| common/build/eslint-config-fluid/printed-configs/strict.json | Added languageOptions section showing projectService: true configuration |
| common/build/eslint-config-fluid/printed-configs/strict-biome.json | Added languageOptions section showing projectService: true configuration |
| common/build/eslint-config-fluid/printed-configs/recommended.json | Added languageOptions section showing projectService: true configuration |
| common/build/eslint-config-fluid/printed-configs/react.json | Added languageOptions section showing projectService: true and JSX ecmaFeatures |
| common/build/eslint-config-fluid/printed-configs/minimal.json | Added languageOptions section showing projectService: true configuration |
| common/build/eslint-config-fluid/printed-configs/default.json | Added languageOptions section showing projectService: true configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the ESLint config printed snapshots to include
languageOptions (excluding the largeglobalsobject). This makes parser options likeprojectService` visible in the printed configs for easier review and debugging of ESLint configuration changes.Changes
print-configs.tsto only removeglobalsfromlanguageOptionsinstead of removing the entirelanguageOptionsblocklanguageOptionssection