Fix for generic type parameters used as constraints for another type parameter.#55
Fix for generic type parameters used as constraints for another type parameter.#55hubuk wants to merge 2 commits intomicrosoft:masterfrom hubuk:issue20
Conversation
hubuk
changed the title
System.Compiler/Reader.cs
Outdated
There was a problem hiding this comment.
💡 Can you correct just the indentation for the contents of the block? In other words, add two spaces at the beginning of each line but don't change any other formatting associated with the block.
There was a problem hiding this comment.
Rebracer may be a nice solution for keeping formatting for the project the same for everybody, works well for me at work.
There was a problem hiding this comment.
I have some doubts about using that (especially considering I'm working on an alternative that doesn't require Visual Studio), but either way it would be a separate issue to consider from this pull request.
There was a problem hiding this comment.
This whole file needs a reformatting as it uses two space indentation.
|
❓ @hubuk Where would a regression test for this be added? |
|
@hubuk could you rebase with master head, please? And could you please at specify the test case when this issue is happening? I'll add tests myself.. |
|
Close as dup. Merged #95 |
4 participants
This should fix #20.