This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Contracts for System.Reflection.CustomAttributeExtensions#180
Merged
SergeyTeplyakov merged 2 commits intomicrosoft:masterfrom Jul 31, 2015
fedotovalex:reflection-extensions-contracts
Merged
Contracts for System.Reflection.CustomAttributeExtensions#180SergeyTeplyakov merged 2 commits intomicrosoft:masterfrom fedotovalex:reflection-extensions-contracts
SergeyTeplyakov merged 2 commits intomicrosoft:masterfrom
fedotovalex:reflection-extensions-contracts
Conversation
Contributor
There was a problem hiding this comment.
❓ Any reason not to make this use IEnumerable<T> instead of IEnumerable<Attribute>? My guess is the current form was easier for copy/paste. I'm assuming the static checker doesn't have a problem with variance like this?
Contributor
Author
There was a problem hiding this comment.
This is a copy/paste typo, thanks for catching it! Fixed now.
Contributor
|
I had one question in the diff but overall 👍 |
Contributor
|
|
SergeyTeplyakov
added a commit
that referenced
this pull request
Jul 31, 2015
Contracts for System.Reflection.CustomAttributeExtensions
Contributor
|
Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds contracts for the System.Reflection.CustomAttributeExtensions class, which is new in .NET framework 4.5.