Allows to pass the settings.json file location via the --settings argument#2668
Merged
Conversation
|
|
rajat2004
reviewed
May 6, 2020
rajat2004
left a comment
rajat2004
left a comment
Contributor
There was a problem hiding this comment.
Wasn't aware of this, thanks!
Contributor
Author
|
just updated the pull request according to your suggestions :) |
Contributor
|
Thanks :) One last thing which will be good to do would be to squash the commits into 1, that keeps the history cleaner and makes life easy for the maintainers |
…ument as a path in addition to passing its content. Also updated documentation, which did not list the other loading possibilities added with microsoft#715.
Contributor
Author
|
@rajat2004 done ;) |
TomSeestern
approved these changes
Jun 23, 2020
Contributor
|
/azp run microsoft.AirSim |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to pass the settings.json file location via the --settings argument as a path in addition to passing its content.
Also updated documentation, which did not list the other loading possibilities added with #715.