Skip to content

Spike: add Puppeteer tests#9

Draft
microbit-rosslowe wants to merge 14 commits intomasterfrom
puppeteer-testing
Draft

Spike: add Puppeteer tests#9
microbit-rosslowe wants to merge 14 commits intomasterfrom
puppeteer-testing

Conversation

@microbit-rosslowe
Copy link
Owner

@microbit-rosslowe microbit-rosslowe commented Jun 5, 2019

Integrate Puppeteer tests into the existing Python Editor tests.

Includes:

  • InvalidTest: Tests that attempting to load a MakeCode hex file will show an error dialog
  • OldTestA: Tests that a v1.0.1 hex file loads correctly
  • OldTestB: Tests that a v0.9 hex file loads correctly
  • URLTest: Tests that loading a project via URL will load the correct content in the editor.

@microbit-rosslowe
Spike: add Puppeteer tests
a0f4f2d 
Integrate Puppeteer tests into the existing Python Editor tests.
@microbit-rosslowe
Copy link
Owner Author

microbit-rosslowe commented Jun 5, 2019

In ./tests run npm i then npm test.

@microbit-rosslowe
Copy link
Owner Author

microbit-rosslowe commented Jun 5, 2019

Move existing tests -> each test should have its own -spec file instead of being integrated into python-spec.js.

@microbit-rosslowe
Restructure tests
25c8f59 
- restructure tests so each test has its own -spec.js file
- start & stop local server after all tests
- remove device aspect of tests, and remove dependencies
@microbit-rosslowe
Copy link
Owner Author

microbit-rosslowe commented Jun 6, 2019

@microbit-carlos I've restructured the tests in 25c8f59

@microbit-rosslowe
Reorganise tests; fix file paths
2a7419b 
Neaten & fix tests by fixing test file paths.
@microbit-rosslowe
Move Puppeteer tests to a single file
2afc415 
Allows us to use a single browser object across all tests.
@microbit-rosslowe
Copy link
Owner Author

microbit-rosslowe commented Jun 12, 2019

@microbit-carlos I've updated the tests so that the Puppeteer tests all belong in a single -spec.js file. This allows for using a single browser object across all tests, and also makes it clear how each test works and where the setup & teardown is. I've also cleaned up the tests so they should all (hopefully!) follow AAA better.

microbit-carlos
microbit-carlos reviewed Jun 17, 2019
View reviewed changes
tests/spec/puppeteer-spec.js Outdated
let fileInput = await page.$('[name="load-form-file-upload"]');
await fileInput.uploadFile('./src/makecode.hex');
await page.click('[value="Load"]');
await page.waitFor(2000);
Copy link
Collaborator

@microbit-carlos microbit-carlos Jun 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to avoid this wait loop?

Copy link
Owner Author

@microbit-rosslowe microbit-rosslowe Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not immediately obvious to me how we could, this also ensures the dialog opens within a given time limit.

@microbit-rosslowe
Updates from feedback
3dcdaf9 
- rearrange AAA
- remove dialogs from old hex tests
- clarify flags
- reduce dialog wait
@microbit-carlos
Copy link
Collaborator

microbit-carlos commented Jun 18, 2019

Great work Ross, this is good to go! Do you want to submit a PR upstream and get it running on azure pipelines?

@microbit-rosslowe microbit-rosslowe force-pushed the puppeteer-testing branch 2 times, most recently from 2e28d99 to 156ac57 Compare June 19, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@microbit-carlos microbit-carlos microbit-carlos left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@microbit-rosslowe @microbit-carlos